Sign upLogin

symplely/dns

View on GitHub
Star

Showing 13 of 17 total issues

Function query has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    public function query($question, $type = 'A'): Answer
    {
        $this->clearError();

        $typeId = $this->types->getByName($type);
Severity: Minor
Found in dns/Query.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readRecord has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function readRecord()
    {
        // First the pesky domain names - maybe not so pesky though I suppose

        $domain = $this->readDomainLabel();
Severity: Minor
Found in dns/Query.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function smartALookup has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function smartALookup($hostname, $depth = 0)
    {
        $this->debug('SmartALookup for ' . $hostname . ' depth ' . $depth);

        // avoid recursive lookups
Severity: Minor
Found in dns/Query.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for ($a = 0; $a < $this->header['nscount']; $a++) {
            $record = $this->readRecord();

            $this->lastNameservers->addResult(new Result($record['header']['type'], $record['typeId'],
                $record['header']['class'], $record['header']['ttl'], $record['data'], $record['domain'],
Severity: Major
Found in dns/Query.php and 1 other location - About 1 hr to fix
dns/Query.php on lines 344..350

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for ($a = 0; $a < $this->header['arcount']; $a++) {
            $record = $this->readRecord();

            $this->lastAdditional->addResult(new Result($record['header']['type'], $record['typeId'],
                $record['header']['class'], $record['header']['ttl'], $record['data'], $record['domain'],
Severity: Major
Found in dns/Query.php and 1 other location - About 1 hr to fix
dns/Query.php on lines 334..340

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 117.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function ShowSection has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

function ShowSection(Answer $result)
{
    global $extendanswer;

    foreach ($result as $index => $record) {
Severity: Minor
Found in examples/index.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function readDomainLabels has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    private function readDomainLabels($offset, &$counter = 0)
    {
        $labels = [];
        $startOffset = $offset;
        $return = false;
Severity: Minor
Found in dns/Query.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($typeId, $type, $class, $ttl, $data, $domain, $string, array $extras)
Severity: Major
Found in dns/Result.php - About 1 hr to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($server = null, $port = 53, $timeout = 60, $udp = true, $debug = false, $binaryDebug = false)
    Severity: Minor
    Found in dns/Query.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

                  return '';
      Severity: Major
      Found in dns/Query.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $best_answer->getData();
        Severity: Major
        Found in dns/Query.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return $result->getData();
          Severity: Major
          Found in dns/Query.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return $this->smartALookup($newTarget, $depth + 1);
            Severity: Major
            Found in dns/Query.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language