Sign upLogin

symplely/hooks

View on GitHub
Star
Hooks/Hooks.php

Summary

Maintainability
C
1 day
Test Coverage

File Hooks.php has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

<?php

declare(strict_types=1);

namespace Async\Hook;
Severity: Minor
Found in Hooks/Hooks.php - About 2 hrs to fix

    Hooks has 24 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    class Hooks implements HooksInterface
{
    /**
     * Holds list of hooks
     * @var array
    Severity: Minor
    Found in Hooks/Hooks.php - About 2 hrs to fix

      Function doAction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function doAction(string $identifier, $arg = '')
    {
        $this->__bump_action($identifier);

        // Do 'all' actions first
      Severity: Minor
      Found in Hooks/Hooks.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method doAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

          public function doAction(string $identifier, $arg = '')
    {
        $this->__bump_action($identifier);

        // Do 'all' actions first
      Severity: Minor
      Found in Hooks/Hooks.php - About 1 hr to fix

        Function hasFilter has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function hasFilter(string $identifier = '', $function = false)
    {
        if (!empty($identifier)) {
            $has = !empty(self::$filters[$identifier]);
            if (false === $function || false == $has)
        Severity: Minor
        Found in Hooks/Hooks.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method applyFilters has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

            public function applyFilters(string $identifier, $value)
    {
        $args = array();
        // Do 'all' actions first
        if (isset(self::$filters['all'])) {
        Severity: Minor
        Found in Hooks/Hooks.php - About 1 hr to fix

          Function applyFilters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function applyFilters(string $identifier, $value)
    {
        $args = array();
        // Do 'all' actions first
        if (isset(self::$filters['all'])) {
          Severity: Minor
          Found in Hooks/Hooks.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function applyFiltersRefArray has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function applyFiltersRefArray(string $identifier, array $args)
    {
        // Do 'all' actions first
        if (isset(self::$filters['all'])) {
            self::$currentFilter[] = $identifier;
          Severity: Minor
          Found in Hooks/Hooks.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function doActionRefArray has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function doActionRefArray(string $identifier, array $args)
    {
        $this->__bump_action($identifier);

        // Do 'all' actions first
          Severity: Minor
          Found in Hooks/Hooks.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function removeAllFilters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function removeAllFilters(string $identifier = '', $priority = false): bool
    {
        if (isset(self::$filters[$identifier])) {
            if (false !== $priority && isset(self::$filters[$identifier][$priority]))
                unset(self::$filters[$identifier][$priority]);
          Severity: Minor
          Found in Hooks/Hooks.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function __filterBuildUniqueId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function __filterBuildUniqueId(string $identifier, $function, $priority)
    {
        static $filter_id_count = 0;

        if (\is_string($function))
          Severity: Minor
          Found in Hooks/Hooks.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  do {
            foreach ((array) \current(self::$filters[$identifier]) as $the_) {
                if (!empty($the_['function']))
                    \call_user_func_array($the_['function'], \array_slice($args, 0, (int) $the_['accepted_args']));
            }
          Severity: Minor
          Found in Hooks/Hooks.php and 1 other location - About 45 mins to fix
          Hooks/Hooks.php on lines 325..330

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  do {
            foreach ((array) \current(self::$filters[$identifier]) as $the_) {
                if (!empty($the_['function']))
                    \call_user_func_array($the_['function'], \array_slice($args, 0, (int) $the_['accepted_args']));
            }
          Severity: Minor
          Found in Hooks/Hooks.php and 1 other location - About 45 mins to fix
          Hooks/Hooks.php on lines 286..291

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 96.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status