Sign upLogin

symplely/hyper

View on GitHub
Star
Request/AsyncStream.php

Summary

Maintainability
C
1 day
Test Coverage

File AsyncStream.php has 465 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

<?php

declare(strict_types=1);

namespace Async\Request;
Severity: Minor
Found in Request/AsyncStream.php - About 7 hrs to fix

    Function getContents has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getContents()
    {
        yield;
        $handle =  $this->getResource();
        if ($this->isReadable() && ($handle !== null)) {
    Severity: Minor
    Found in Request/AsyncStream.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    AsyncStream has 31 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    class AsyncStream implements StreamInterface
{
    /**
     * @var string[]
     */
    Severity: Minor
    Found in Request/AsyncStream.php - About 3 hrs to fix

      Function read has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function read($length)
    {
        $handle =  $this->getResource();
        if (!$this->isReadable() || ($handle === null)) {
            yield \log_critical('Stream is not readable', \hyper_loggerName());
      Severity: Minor
      Found in Request/AsyncStream.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getContents has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

          public function getContents()
    {
        yield;
        $handle =  $this->getResource();
        if ($this->isReadable() && ($handle !== null)) {
      Severity: Minor
      Found in Request/AsyncStream.php - About 1 hr to fix

        Method read has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

            public function read($length)
    {
        $handle =  $this->getResource();
        if (!$this->isReadable() || ($handle === null)) {
            yield \log_critical('Stream is not readable', \hyper_loggerName());
        Severity: Minor
        Found in Request/AsyncStream.php - About 1 hr to fix

          Method copyResource has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

              public static function copyResource($source, $destination = null)
    {
        $source = $source instanceof AsyncStream ? $source->getResource() : $source;
        $destination = $destination instanceof AsyncStream ? $destination->getResource() : $destination;
        if (!\is_resource($source)) {
          Severity: Minor
          Found in Request/AsyncStream.php - About 1 hr to fix

            Function copyResource has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function copyResource($source, $destination = null)
    {
        $source = $source instanceof AsyncStream ? $source->getResource() : $source;
        $destination = $destination instanceof AsyncStream ? $destination->getResource() : $destination;
        if (!\is_resource($source)) {
            Severity: Minor
            Found in Request/AsyncStream.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function write has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function write($string)
    {
        $handle =  $this->getResource();
        if (!$this->isWritable() || ($handle === null)) {
            yield \log_critical('Stream is not writable', \hyper_loggerName());
            Severity: Minor
            Found in Request/AsyncStream.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function inflateRead has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected static function inflateRead(AsyncStream $stream, $handle)
    {
        $chunk = false;
        if (false !== ($data = \fread($handle, 8192))) {
            $chunk = @\inflate_add($stream->contextInflate, $data, \ZLIB_SYNC_FLUSH);
            Severity: Minor
            Found in Request/AsyncStream.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (false !== $contents) {
                yield \log_notice(
                    'On task: {httpId} {class}, {url} Read: {read} bytes Took: {timer}ms',
                    ['httpId' => $this->hyperId, 'class' => __METHOD__, 'url' => $this->uri, 'read' => \strlen($contents), 'timer' => $timer],
                    \hyper_loggerName()
            Severity: Major
            Found in Request/AsyncStream.php and 1 other location - About 1 hr to fix
            Request/AsyncStream.php on lines 401..412

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (false !== $buffer) {
                yield \log_notice(
                    'On task: {httpId} {class}, {url} Received: {transferred} bytes Took: {timer}ms',
                    ['httpId' => $this->hyperId, 'class' => __METHOD__, 'url' => $this->uri, 'transferred' => \strlen($buffer), 'timer' => $timer],
                    \hyper_loggerName()
            Severity: Major
            Found in Request/AsyncStream.php and 1 other location - About 1 hr to fix
            Request/AsyncStream.php on lines 454..465

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                public function isReadable()
    {
        $handle = $this->getResource();

        if ($handle === null) {
            Severity: Major
            Found in Request/AsyncStream.php and 1 other location - About 1 hr to fix
            Request/AsyncStream.php on lines 592..607

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Wontfix

                public function isWritable($stream = null)
    {
        $handle = $this->getResource();

        if ($handle === null) {
            Severity: Major
            Found in Request/AsyncStream.php and 1 other location - About 1 hr to fix
            Request/AsyncStream.php on lines 572..587

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 109.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status