Sign upLogin

symplely/menu

View on GitHub
Star

Showing 13 of 14 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function attributes()
    {
        $args = \func_get_args();

        if (isset($args[0]) && \is_array($args[0])) {
Severity: Major
Found in Menu/Item.php and 2 other locations - About 4 hrs to fix
Menu/Item.php on lines 170..185
Menu/Link.php on lines 119..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function meta()
    {
        $args = \func_get_args();

        if (isset($args[0]) && \is_array($args[0])) {
Severity: Major
Found in Menu/Item.php and 2 other locations - About 4 hrs to fix
Menu/Item.php on lines 148..163
Menu/Link.php on lines 119..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function attributes()
    {
        $args = \func_get_args();

        if (isset($args[0]) && \is_array($args[0])) {
Severity: Major
Found in Menu/Link.php and 2 other locations - About 4 hrs to fix
Menu/Item.php on lines 148..163
Menu/Item.php on lines 170..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function bootstrap_menu has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    function bootstrap_menu($items, string $extra = '')
    {
        // Starting from items at root level
        if (!\is_array($items)) {
            $items = $items->roots();
Severity: Minor
Found in Menu/Core.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create_menu has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    function create_menu(?string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '', ?Menu $menu = null)
    {
        if (empty($menu))
            $menu = new Menu;
Severity: Minor
Found in Menu/Core.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create_menu has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    function create_menu(?string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '', ?Menu $menu = null)
Severity: Minor
Found in Menu/Core.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($manager, $title, $url, $attributes = array(), $pid = 0)
    Severity: Minor
    Found in Menu/Item.php - About 35 mins to fix

      Method create_menuSub has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          function create_menuSub(Menu $menu, string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '')
      Severity: Minor
      Found in Menu/Core.php - About 35 mins to fix

        Method create_menuItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function create_menuItem(Item $item, string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '')
        Severity: Minor
        Found in Menu/Core.php - About 35 mins to fix

          Function renderAttributes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function renderAttributes(): string
    {
        if (empty($this->attributes) && empty($this->classes)) {
            return '';
        }
          Severity: Minor
          Found in Menu/Link.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function setAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setAttributes(array $attributes)
    {
        foreach ($attributes as $attribute => $value) {
            if ($attribute === 'class') {
                $this->addClass($value);
          Severity: Minor
          Found in Menu/Link.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create_menuSub has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              function create_menuSub(Menu $menu, string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '')
    {
        $subMenu = $menu->add($name, ['url' => $url, 'class' => 'submenu']);
        $subMenu->caret();
        if (!empty($icon)) {
          Severity: Minor
          Found in Menu/Core.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function create_menuItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              function create_menuItem(Item $item, string $url = "#", ?string $name = '', ?string $icon = '', ?string $type = '')
    {
        $item->add($name, $url);
        if (!empty($icon)) {
            if ($type == "img") {
          Severity: Minor
          Found in Menu/Core.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language