sympmarc/SPServices

View on GitHub

Showing 43 of 105 total issues

Avoid deeply nested control flow statements.
Open

                                                if ($(this).attr("ID").substring(0, 6) !== "0x0120") {
                                                    var formUrls = $(this).find("FormUrls");
                                                    for (var i = 0; i < formTypes.length; i++) {
                                                        // Look for a customized form...
                                                        $(formUrls).find(formTypes[i][0]).each(function () {
Severity: Major
Found in src/value-added/SPScriptAudit.js - About 45 mins to fix

    Function SPScriptAuditPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        function SPScriptAuditPage(opt, listXml, pageClass, pageType, pageUrl) {
    Severity: Minor
    Found in src/value-added/SPScriptAudit.js - About 35 mins to fix

      Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {
          require('jit-grunt')(grunt);
      
          "use strict";
      
      
      Severity: Minor
      Found in Gruntfile.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language