Sign upLogin

synapsecns/sanguine

View on GitHub
Star
agents/agents/executor/db/sql/base/message.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Store.StoreMessage has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (s Store) StoreMessage(ctx context.Context, message agentsTypes.Message, blockNumber uint64, minimumTimeSet bool, minimumTime uint64) error {
Severity: Minor
Found in agents/agents/executor/db/sql/base/message.go - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func DBMessageToMessage(dbMessage db.DBMessage) Message {
    var message Message

    if dbMessage.ChainID != nil {
        message.ChainID = *dbMessage.ChainID
    Severity: Major
    Found in agents/agents/executor/db/sql/base/message.go and 1 other location - About 3 hrs to fix
    agents/agents/executor/db/sql/base/attestation.go on lines 127..163

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 274.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func MessageToDBMessage(message Message) db.DBMessage {
    chainID := message.ChainID
    destination := message.Destination
    nonce := message.Nonce
    messageBytes := message.Message
    Severity: Major
    Found in agents/agents/executor/db/sql/base/message.go and 1 other location - About 1 hr to fix
    agents/agents/executor/db/sql/base/attestation.go on lines 166..186

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status