Sign upLogin

synapsecns/sanguine

View on GitHub
Star
agents/config/agent_config.go

Summary

Maintainability
A
1 hr
Test Coverage

Method AgentConfig.IsValid has 5 return statements (exceeds 4 allowed).
Open

func (a *AgentConfig) IsValid(ctx context.Context) (ok bool, err error) {
    if int64(a.RefreshIntervalSeconds) == int64(0) {
        return false, fmt.Errorf("refresh_interval_seconds cannot be 0")
    }
Severity: Major
Found in agents/config/agent_config.go - About 35 mins to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

    func DecodeAgentConfig(filePath string) (a AgentConfig, err error) {
    input, err := os.ReadFile(filepath.Clean(filePath))
    if err != nil {
        return AgentConfig{}, fmt.Errorf("failed to read file: %w", err)
    }
    Severity: Major
    Found in agents/config/agent_config.go and 6 other locations - About 1 hr to fix
    agents/config/executor/config.go on lines 81..91
    ethergo/signer/config/signer.go on lines 180..190
    ethergo/signer/config/signer.go on lines 215..225
    services/cctp-relayer/config/config.go on lines 84..94
    services/rfq/api/config/config.go on lines 52..62
    services/scribe/config/config.go on lines 46..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status