Sign upLogin

synapsecns/sanguine

View on GitHub
Star
agents/domains/evm/lightinbox.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method lightInboxContract.SubmitAttestation has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    transactor *bind.TransactOpts,
    attPayload []byte,
    signature signer.Signature,
    agentRoot [32]byte,
    snapGas []*big.Int,
Severity: Minor
Found in agents/domains/evm/lightinbox.go - About 35 mins to fix

    Method lightInboxContract.SubmitStateReportWithSnapshot has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (a lightInboxContract) SubmitStateReportWithSnapshot(transactor *bind.TransactOpts, stateIndex uint8, signature signer.Signature, snapPayload []byte, snapSignature []byte) (tx *ethTypes.Transaction, err error) {
    Severity: Minor
    Found in agents/domains/evm/lightinbox.go - About 35 mins to fix

      Method lightInboxContract.VerifyStateWithAttestation has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func (a lightInboxContract) VerifyStateWithAttestation(transactor *bind.TransactOpts, stateIndex uint8, snapPayload []byte, attPayload []byte, attSignature []byte) (tx *ethTypes.Transaction, err error) {
      Severity: Minor
      Found in agents/domains/evm/lightinbox.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (a lightInboxContract) SubmitStateReportWithSnapshot(transactor *bind.TransactOpts, stateIndex uint8, signature signer.Signature, snapPayload []byte, snapSignature []byte) (tx *ethTypes.Transaction, err error) {
    rawSig, err := types.EncodeSignature(signature)
    if err != nil {
        return nil, fmt.Errorf("could not encode signature: %w", err)
    }
        Severity: Major
        Found in agents/domains/evm/lightinbox.go and 1 other location - About 1 hr to fix
        agents/domains/evm/inbox.go on lines 48..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 167.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

        func NewLightInboxContract(ctx context.Context, client chain.Chain, lightInboxAddress common.Address) (domains.LightInboxContract, error) {
    boundCountract, err := lightinbox.NewLightInboxRef(lightInboxAddress, client)
    if err != nil {
        return nil, fmt.Errorf("could not create %T: %w", &lightinbox.LightInboxRef{}, err)
    }
        Severity: Major
        Found in agents/domains/evm/lightinbox.go and 8 other locations - About 1 hr to fix
        agents/domains/evm/bondingmanager.go on lines 24..36
        agents/domains/evm/destination.go on lines 21..33
        agents/domains/evm/inbox.go on lines 22..34
        agents/domains/evm/lightmanager.go on lines 24..36
        agents/domains/evm/origin.go on lines 19..32
        agents/domains/evm/pingpongtestclient.go on lines 20..32
        agents/domains/evm/summit.go on lines 21..33
        agents/domains/evm/testclient.go on lines 18..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 147.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (a lightInboxContract) VerifyReceipt(transactor *bind.TransactOpts, rcptPayload []byte, rcptSignature []byte) (tx *ethTypes.Transaction, err error) {
    tx, err = a.contract.VerifyReceipt(transactor, rcptPayload, rcptSignature)
    if err != nil {
        return nil, fmt.Errorf("could not submit state report: %w", err)
    }
        Severity: Major
        Found in agents/domains/evm/lightinbox.go and 2 other locations - About 40 mins to fix
        agents/domains/evm/inbox.go on lines 76..83
        agents/domains/evm/inbox.go on lines 113..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status