Sign upLogin

synapsecns/sanguine

View on GitHub
Star
agents/domains/evm/summit.go

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 9 locations. Consider refactoring.
Open

func NewSummitContract(ctx context.Context, client chain.Chain, summitAddress common.Address) (domains.SummitContract, error) {
    boundCountract, err := summit.NewSummitRef(summitAddress, client)
    if err != nil {
        return nil, fmt.Errorf("could not create %T: %w", &summit.SummitRef{}, err)
    }
Severity: Major
Found in agents/domains/evm/summit.go and 8 other locations - About 1 hr to fix
agents/domains/evm/bondingmanager.go on lines 24..36
agents/domains/evm/destination.go on lines 21..33
agents/domains/evm/inbox.go on lines 22..34
agents/domains/evm/lightinbox.go on lines 22..34
agents/domains/evm/lightmanager.go on lines 24..36
agents/domains/evm/origin.go on lines 19..32
agents/domains/evm/pingpongtestclient.go on lines 20..32
agents/domains/evm/testclient.go on lines 18..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (a summitContract) WatchAttestationSaved(ctx context.Context, sink chan<- *summit.SummitAttestationSaved) (event.Subscription, error) {
    sub, err := a.contract.WatchAttestationSaved(&bind.WatchOpts{Context: ctx}, sink)
    if err != nil {
        return nil, fmt.Errorf("could set up channel to watch attestation saved: %w", err)
    }
Severity: Major
Found in agents/domains/evm/summit.go and 2 other locations - About 45 mins to fix
agents/domains/evm/pingpongtestclient.go on lines 58..65
agents/domains/evm/pingpongtestclient.go on lines 67..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 114.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status