Sign upLogin

synapsecns/sanguine

View on GitHub
Star
core/processlog/stream_test.go

Summary

Maintainability
D
2 days
Test Coverage

Function TestNewBufferedPipe has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func TestNewBufferedPipe(t *testing.T) {
    t.Run("Write and read data", func(t *testing.T) {
        pipe := processlog.NewBufferedPipe()

        testData := []byte("Hello, World!")
Severity: Minor
Found in core/processlog/stream_test.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestCombineStreams has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func TestCombineStreams(t *testing.T) {
    tests := []struct {
        name           string
        inputs         []string
        expectedOutput []string
Severity: Minor
Found in core/processlog/stream_test.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function TestNewBufferedPipe has 70 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestNewBufferedPipe(t *testing.T) {
    t.Run("Write and read data", func(t *testing.T) {
        pipe := processlog.NewBufferedPipe()

        testData := []byte("Hello, World!")
Severity: Minor
Found in core/processlog/stream_test.go - About 1 hr to fix

    Function TestCombineStreams has 64 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestCombineStreams(t *testing.T) {
    tests := []struct {
        name           string
        inputs         []string
        expectedOutput []string
    Severity: Minor
    Found in core/processlog/stream_test.go - About 1 hr to fix

      Function TestNewBufferedPipe has 6 return statements (exceeds 4 allowed).
      Open

      func TestNewBufferedPipe(t *testing.T) {
    t.Run("Write and read data", func(t *testing.T) {
        pipe := processlog.NewBufferedPipe()

        testData := []byte("Hello, World!")
      Severity: Major
      Found in core/processlog/stream_test.go - About 40 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            t.Run("Close writer before reading", func(t *testing.T) {
        pipe := processlog.NewBufferedPipe()

        testData := []byte("Hello, World!")
        Severity: Major
        Found in core/processlog/stream_test.go and 1 other location - About 4 hrs to fix
        core/processlog/stream_test.go on lines 207..246

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 315.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            t.Run("Write and read data", func(t *testing.T) {
        pipe := processlog.NewBufferedPipe()

        testData := []byte("Hello, World!")
        Severity: Major
        Found in core/processlog/stream_test.go and 1 other location - About 4 hrs to fix
        core/processlog/stream_test.go on lines 248..287

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 315.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status