synapsecns/sanguine

View on GitHub
ethergo/chain/block.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method baseChain.HeaderByTime has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
Open

func (b *baseChain) HeaderByTime(ctx context.Context, startHeight *big.Int, targetTime time.Time) (*types.Header, error) {
    // grab the MeteredEVMClient explicitly to avoid ambiguous references
    client, err := newHeaderCacheClient(b, 4)
    if err != nil {
        return nil, fmt.Errorf("could not create header cache client: %w", err)
Severity: Minor
Found in ethergo/chain/block.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method baseChain.HeaderByTime has 12 return statements (exceeds 4 allowed).
Open

func (b *baseChain) HeaderByTime(ctx context.Context, startHeight *big.Int, targetTime time.Time) (*types.Header, error) {
    // grab the MeteredEVMClient explicitly to avoid ambiguous references
    client, err := newHeaderCacheClient(b, 4)
    if err != nil {
        return nil, fmt.Errorf("could not create header cache client: %w", err)
Severity: Major
Found in ethergo/chain/block.go - About 1 hr to fix

    Method baseChain.HeaderByTime has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (b *baseChain) HeaderByTime(ctx context.Context, startHeight *big.Int, targetTime time.Time) (*types.Header, error) {
        // grab the MeteredEVMClient explicitly to avoid ambiguous references
        client, err := newHeaderCacheClient(b, 4)
        if err != nil {
            return nil, fmt.Errorf("could not create header cache client: %w", err)
    Severity: Minor
    Found in ethergo/chain/block.go - About 1 hr to fix

      Function getSearchRange has 6 return statements (exceeds 4 allowed).
      Open

      func getSearchRange(ctx context.Context, client ethereum.ChainReader, startHeight *big.Int) (_ *blockRange, err error) {
          var output blockRange
          if startHeight == nil || startHeight.Cmp(big.NewInt(0)) == 0 {
              startHeight = big.NewInt(1)
          }
      Severity: Major
      Found in ethergo/chain/block.go - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status