Sign upLogin

synapsecns/sanguine

View on GitHub
Star
ethergo/chain/watcher/contractwatcher_test.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method WatcherSuite.TestListeners has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (s *WatcherSuite) TestListeners() {
    // timeout the test after thie period
    ctx, cancel := context.WithTimeout(s.GetTestContext(), 30*time.Second)
    defer cancel()
Severity: Minor
Found in ethergo/chain/watcher/contractwatcher_test.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method WatcherSuite.TestContractWatcherRetry has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *WatcherSuite) TestContractWatcherRetry() {
    if os.Getenv("CI") != "" {
        s.T().Skip("this flakes on ci. TODO fix this. This should never fail locally.")
    }
    const requiredConfs = 3
Severity: Minor
Found in ethergo/chain/watcher/contractwatcher_test.go - About 1 hr to fix

    Method WatcherSuite.TestListeners has 51 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (s *WatcherSuite) TestListeners() {
    // timeout the test after thie period
    ctx, cancel := context.WithTimeout(s.GetTestContext(), 30*time.Second)
    defer cancel()
    Severity: Minor
    Found in ethergo/chain/watcher/contractwatcher_test.go - About 1 hr to fix

      Method WatcherSuite.TestContractWatcherRetry has 7 return statements (exceeds 4 allowed).
      Open

      func (s *WatcherSuite) TestContractWatcherRetry() {
    if os.Getenv("CI") != "" {
        s.T().Skip("this flakes on ci. TODO fix this. This should never fail locally.")
    }
    const requiredConfs = 3
      Severity: Major
      Found in ethergo/chain/watcher/contractwatcher_test.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status