Sign upLogin

synapsecns/sanguine

View on GitHub
Star
ethergo/listener/listener_test.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method ListenerTestSuite.TestListenForEvents has 85 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (l *ListenerTestSuite) TestListenForEvents() {
    _, handle := l.manager.GetCounter(l.GetTestContext(), l.backend)
    var wg sync.WaitGroup
    const iterations = 10
    for i := 0; i < iterations; i++ {
Severity: Major
Found in ethergo/listener/listener_test.go - About 2 hrs to fix

    Method ListenerTestSuite.TestListenForEvents has 6 return statements (exceeds 4 allowed).
    Open

    func (l *ListenerTestSuite) TestListenForEvents() {
    _, handle := l.manager.GetCounter(l.GetTestContext(), l.backend)
    var wg sync.WaitGroup
    const iterations = 10
    for i := 0; i < iterations; i++ {
    Severity: Major
    Found in ethergo/listener/listener_test.go - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          clFinalized, err := listener.NewChainListener(
        l.backend,
        l.store,
        handle.Address(),
        uint64(startBlock.Int64()),
      Severity: Minor
      Found in ethergo/listener/listener_test.go and 1 other location - About 45 mins to fix
      ethergo/listener/listener_test.go on lines 54..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          clSafe, err := listener.NewChainListener(
        l.backend,
        l.store,
        handle.Address(),
        uint64(startBlock.Int64()),
      Severity: Minor
      Found in ethergo/listener/listener_test.go and 1 other location - About 45 mins to fix
      ethergo/listener/listener_test.go on lines 69..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status