Sign upLogin

synapsecns/sanguine

View on GitHub
Star
packages/rest-api/src/controllers/bridgeController.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function bridgeController has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const bridgeController = async (req, res) => {
  const errors = validationResult(req)
  if (!errors.isEmpty()) {
    return res.status(400).json({ errors: errors.array() })
  }
Severity: Major
Found in packages/rest-api/src/controllers/bridgeController.ts - About 3 hrs to fix

    Function payload has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          resp.map(async (quote) => {
        const originQueryTokenOutInfo = tokenAddressToToken(
          fromChain.toString(),
          quote.originQuery.tokenOut
        )
    Severity: Minor
    Found in packages/rest-api/src/controllers/bridgeController.ts - About 1 hr to fix

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        try {
    const {
      fromChain,
      toChain,
      amount,
      Severity: Major
      Found in packages/rest-api/src/controllers/bridgeController.ts and 7 other locations - About 2 hrs to fix
      packages/rest-api/src/controllers/bridgeLimitsController.ts on lines 15..118
      packages/rest-api/src/controllers/bridgeTxInfoController.ts on lines 14..71
      packages/rest-api/src/controllers/bridgeTxStatusController.ts on lines 15..89
      packages/rest-api/src/controllers/indexController.ts on lines 6..37
      packages/rest-api/src/controllers/swapController.ts on lines 14..63
      packages/rest-api/src/controllers/swapTxInfoController.ts on lines 14..51
      packages/rest-api/src/controllers/synapseTxIdController.ts on lines 12..40

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const resp = await Synapse.allBridgeQuotes(
      Number(fromChain),
      Number(toChain),
      fromToken,
      toToken,
      Severity: Minor
      Found in packages/rest-api/src/controllers/bridgeController.ts and 1 other location - About 45 mins to fix
      packages/rest-api/src/controllers/bridgeTxInfoController.ts on lines 29..38

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 9 locations. Consider refactoring.
      Open

        if (!errors.isEmpty()) {
    return res.status(400).json({ errors: errors.array() })
  }
      Severity: Major
      Found in packages/rest-api/src/controllers/bridgeController.ts and 8 other locations - About 40 mins to fix
      packages/rest-api/src/controllers/bridgeLimitsController.ts on lines 12..14
      packages/rest-api/src/controllers/bridgeTxInfoController.ts on lines 10..12
      packages/rest-api/src/controllers/bridgeTxStatusController.ts on lines 11..13
      packages/rest-api/src/controllers/destinationTokensController.ts on lines 9..11
      packages/rest-api/src/controllers/destinationTxController.ts on lines 11..13
      packages/rest-api/src/controllers/swapController.ts on lines 11..13
      packages/rest-api/src/controllers/swapTxInfoController.ts on lines 10..12
      packages/rest-api/src/controllers/synapseTxIdController.ts on lines 8..10

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status