Sign upLogin

synapsecns/sanguine

View on GitHub
Star
packages/sdk-router/src/operations/bridge.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function allBridgeQuotes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function allBridgeQuotes(
  this: SynapseSDK,
  originChainId: number,
  destChainId: number,
  tokenIn: string,
Severity: Minor
Found in packages/sdk-router/src/operations/bridge.ts - About 1 hr to fix

    Function bridge has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      this: SynapseSDK,
  to: string,
  originRouterAddress: string,
  originChainId: number,
  destChainId: number,
    Severity: Major
    Found in packages/sdk-router/src/operations/bridge.ts - About 1 hr to fix

      Function allBridgeQuotes has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        this: SynapseSDK,
  originChainId: number,
  destChainId: number,
  tokenIn: string,
  tokenOut: string,
      Severity: Major
      Found in packages/sdk-router/src/operations/bridge.ts - About 50 mins to fix

        Function bridgeQuote has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          this: SynapseSDK,
  originChainId: number,
  destChainId: number,
  tokenIn: string,
  tokenOut: string,
        Severity: Major
        Found in packages/sdk-router/src/operations/bridge.ts - About 50 mins to fix

          Function applyBridgeDeadline has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            this: SynapseSDK,
  bridgeModuleName: string,
  originQueryInitial: Query,
  destQueryInitial: Query,
  originDeadline?: BigNumber,
          Severity: Minor
          Found in packages/sdk-router/src/operations/bridge.ts - About 45 mins to fix

            Function applyBridgeSlippage has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              this: SynapseSDK,
  bridgeModuleName: string,
  originQueryInitial: Query,
  destQueryInitial: Query,
  slipNumerator: number = 10,
            Severity: Minor
            Found in packages/sdk-router/src/operations/bridge.ts - About 45 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              export async function allBridgeQuotes(
  this: SynapseSDK,
  originChainId: number,
  destChainId: number,
  tokenIn: string,
              Severity: Minor
              Found in packages/sdk-router/src/operations/bridge.ts and 1 other location - About 35 mins to fix
              packages/sdk-router/src/operations/bridge.ts on lines 96..120

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

              export async function bridgeQuote(
  this: SynapseSDK,
  originChainId: number,
  destChainId: number,
  tokenIn: string,
              Severity: Minor
              Found in packages/sdk-router/src/operations/bridge.ts and 1 other location - About 35 mins to fix
              packages/sdk-router/src/operations/bridge.ts on lines 143..186

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status