synapsecns/sanguine

View on GitHub
packages/synapse-constants/src/types/index.ts

Summary

Maintainability
C
1 day
Test Coverage

File index.ts has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { BigNumber } from '@ethersproject/bignumber'

import { makeMultiChainObj } from '../utils/makeMultiChainObj'
import { validateAddresses } from '../utils/validateAddresses'

Severity: Minor
Found in packages/synapse-constants/src/types/index.ts - About 2 hrs to fix

    Function constructor has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor({
        addresses,
        wrapperAddresses,
        decimals,
        symbol,
    Severity: Minor
    Found in packages/synapse-constants/src/types/index.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export type PoolData = {
        name: string
        tokens: PoolToken[]
        totalLocked: number
        totalLockedUSD: number
      Severity: Major
      Found in packages/synapse-constants/src/types/index.ts and 1 other location - About 1 hr to fix
      packages/synapse-interface/utils/types/index.tsx on lines 54..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      export type Query = [string, string, BigNumber, BigNumber, string] & {
        swapAdapter: string
        tokenOut: string
        minAmountOut: BigNumber
        deadline: BigNumber
      Severity: Major
      Found in packages/synapse-constants/src/types/index.ts and 4 other locations - About 1 hr to fix
      packages/sdk-router/src/typechain/FastBridgeRouter.ts on lines 38..50
      packages/sdk-router/src/typechain/SynapseCCTPRouter.ts on lines 33..45
      packages/sdk-router/src/typechain/SynapseRouter.ts on lines 57..69
      packages/synapse-interface/utils/types/index.tsx on lines 37..43

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      export type PoolToken = {
        symbol: string
        percent: string
        balance: string
        balanceStr: string
      Severity: Major
      Found in packages/synapse-constants/src/types/index.ts and 1 other location - About 1 hr to fix
      packages/synapse-interface/utils/types/index.tsx on lines 28..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        category: { bridge: boolean; swap: boolean; pool: boolean } = {
          bridge: true,
          swap: true,
          pool: true,
        } // list of categories on each chain
      Severity: Minor
      Found in packages/synapse-constants/src/types/index.ts and 1 other location - About 50 mins to fix
      packages/synapse-interface/utils/types/index.tsx on lines 181..185

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status