Sign upLogin

synapsecns/sanguine

View on GitHub
Star
packages/synapse-interface/slices/swap/reducer.ts

Summary

Maintainability
F
4 days
Test Coverage

Function setSwapChainId has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setSwapChainId: (state, action: PayloadAction<number>) => {
      const incomingFromChainId = action.payload

      const validFromTokens = _(
        getSwapFromTokens({
Severity: Major
Found in packages/synapse-interface/slices/swap/reducer.ts - About 2 hrs to fix

    Function setSwapFromToken has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        setSwapFromToken: (state, action: PayloadAction<Token>) => {
      const incomingFromToken = action.payload

      const validFromChainIds = getSwapFromChainIds({
        fromChainId: state.swapChainId ?? null,
    Severity: Major
    Found in packages/synapse-interface/slices/swap/reducer.ts - About 2 hrs to fix

      Function setSwapToToken has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setSwapToToken: (state, action: PayloadAction<Token>) => {
      const incomingToToken = action.payload

      const validFromChainIds = getSwapFromChainIds({
        fromChainId: state.swapChainId ?? null,
      Severity: Major
      Found in packages/synapse-interface/slices/swap/reducer.ts - About 2 hrs to fix

        File reducer.ts has 265 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import _ from 'lodash'
import { createSlice, PayloadAction } from '@reduxjs/toolkit'

import { DAI, USDC } from '@/constants/tokens/bridgeable'
import { EMPTY_SWAP_QUOTE } from '@/constants/swap'
        Severity: Minor
        Found in packages/synapse-interface/slices/swap/reducer.ts - About 2 hrs to fix

          Function setSwapChainId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              setSwapChainId: (state, action: PayloadAction<number>) => {
      const incomingFromChainId = action.payload

      const validFromTokens = _(
        getSwapFromTokens({
          Severity: Minor
          Found in packages/synapse-interface/slices/swap/reducer.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const validFromTokens = _(
        getSwapFromTokens({
          fromChainId: incomingFromChainId ?? null,
          fromTokenRouteSymbol: state.swapFromToken?.routeSymbol ?? null,
          toChainId: incomingFromChainId ?? null,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 1 other location - About 3 hrs to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 75..87

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const validToTokens = _(
        getSwapToTokens({
          fromChainId: incomingFromChainId ?? null,
          fromTokenRouteSymbol: state.swapFromToken?.routeSymbol ?? null,
          toChainId: incomingFromChainId ?? null,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 1 other location - About 3 hrs to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 61..73

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                if (
        validFromTokens?.some(
          (token) => token?.routeSymbol === state.swapFromToken?.routeSymbol
        )
      ) {
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 5 other locations - About 2 hrs to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 106..118
          packages/widget/src/state/slices/bridge/reducer.ts on lines 94..106
          packages/widget/src/state/slices/bridge/reducer.ts on lines 117..129
          packages/widget/src/state/slices/bridge/reducer.ts on lines 287..299
          packages/widget/src/state/slices/bridge/reducer.ts on lines 301..313

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 79.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                if (
        validToTokens?.some(
          (token) => token?.routeSymbol === state.swapToToken?.routeSymbol
        )
      ) {
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 5 other locations - About 2 hrs to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 92..104
          packages/widget/src/state/slices/bridge/reducer.ts on lines 94..106
          packages/widget/src/state/slices/bridge/reducer.ts on lines 117..129
          packages/widget/src/state/slices/bridge/reducer.ts on lines 287..299
          packages/widget/src/state/slices/bridge/reducer.ts on lines 301..313

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 79.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                if (
        validFromTokens?.some(
          (token) => token?.routeSymbol === state.swapFromToken?.routeSymbol
        )
      ) {
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 3 other locations - About 1 hr to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 174..186
          packages/widget/src/state/slices/bridge/reducer.ts on lines 202..214
          packages/widget/src/state/slices/bridge/reducer.ts on lines 380..392

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                if (
        validToTokens?.some(
          (token) => token?.routeSymbol === state.swapToToken?.routeSymbol
        )
      ) {
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 3 other locations - About 1 hr to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 242..254
          packages/widget/src/state/slices/bridge/reducer.ts on lines 202..214
          packages/widget/src/state/slices/bridge/reducer.ts on lines 380..392

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                const {
        fromChainId,
        fromToken,
        toToken,
        fromChainIds,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 2 other locations - About 1 hr to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 120..132
          packages/synapse-interface/slices/swap/reducer.ts on lines 256..268

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                const {
        fromChainId,
        fromToken,
        toToken,
        fromChainIds,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 2 other locations - About 1 hr to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 120..132
          packages/synapse-interface/slices/swap/reducer.ts on lines 188..200

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                const {
        fromChainId,
        fromToken,
        toToken,
        fromChainIds,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 2 other locations - About 1 hr to fix
          packages/synapse-interface/slices/swap/reducer.ts on lines 188..200
          packages/synapse-interface/slices/swap/reducer.ts on lines 256..268

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  getSwapFromTokens({
          fromChainId: state.swapChainId ?? null,
          fromTokenRouteSymbol: state.swapFromToken?.routeSymbol ?? null,
          toChainId: state.swapChainId ?? null,
          toTokenRouteSymbol: incomingToToken?.routeSymbol ?? null,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 1 other location - About 1 hr to fix
          packages/widget/src/state/slices/bridge/reducer.ts on lines 353..358

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                const validFromChainIds = getSwapFromChainIds({
        fromChainId: state.swapChainId ?? null,
        fromTokenRouteSymbol: null,
        toChainId: state.swapChainId ?? null,
        toTokenRouteSymbol: incomingToToken?.routeSymbol ?? null,
          Severity: Major
          Found in packages/synapse-interface/slices/swap/reducer.ts and 1 other location - About 1 hr to fix
          packages/widget/src/state/slices/bridge/reducer.ts on lines 346..351

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  getSwapToTokens({
          fromChainId: state.swapChainId ?? null,
          fromTokenRouteSymbol: incomingFromToken?.routeSymbol ?? null,
          toChainId: state.swapChainId ?? null,
          toTokenRouteSymbol: null,
          Severity: Minor
          Found in packages/synapse-interface/slices/swap/reducer.ts and 1 other location - About 45 mins to fix
          packages/widget/src/state/slices/bridge/reducer.ts on lines 176..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                const validFromChainIds = getSwapFromChainIds({
        fromChainId: state.swapChainId ?? null,
        fromTokenRouteSymbol: incomingFromToken?.routeSymbol ?? null,
        toChainId: null,
        toTokenRouteSymbol: null,
          Severity: Minor
          Found in packages/synapse-interface/slices/swap/reducer.ts and 2 other locations - About 40 mins to fix
          packages/widget/src/state/slices/bridge/reducer.ts on lines 162..167
          packages/widget/src/state/slices/bridge/reducer.ts on lines 169..174

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status