Sign upLogin

synapsecns/sanguine

View on GitHub
Star
packages/synapse-interface/utils/actions/approveAndDeposit.tsx

Summary

Maintainability
D
2 days
Test Coverage

Function deposit has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const deposit = async (
  pool: Token,
  slippageSelected: any,
  slippageCustom: any,
  inputAmounts: any,
Severity: Major
Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 3 hrs to fix

    Function approve has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const approve = async (
  pool: Token,
  depositQuote: any,
  inputValue: Record<string, bigint>,
  chainId: number
    Severity: Major
    Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 2 hrs to fix

      Function emptyPoolDeposit has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const emptyPoolDeposit = async (
  pool: Token,
  inputAmounts: any,
  chainId: number
) => {
      Severity: Major
      Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 2 hrs to fix

        Function approve has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

        export const approve = async (
  pool: Token,
  depositQuote: any,
  inputValue: Record<string, bigint>,
  chainId: number
        Severity: Minor
        Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File approveAndDeposit.tsx has 252 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import _ from 'lodash'
import { zeroAddress } from 'viem'
import toast from 'react-hot-toast'

import { subtractSlippageBigInt } from '@utils/slippage'
        Severity: Minor
        Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 2 hrs to fix

          Function handleApproval has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const handleApproval = async (token, tokenAddr) => {
    if (
      inputValue[tokenAddr] &&
      (inputValue[tokenAddr] === 0n ||
        inputValue[tokenAddr] <= depositQuote.allowances[tokenAddr])
          Severity: Minor
          Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              try {
    // get this from quote?
    segmentAnalyticsEvent(
      `[Pool Deposit] Attempt`,
      {
            Severity: Major
            Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx and 1 other location - About 2 hrs to fix
            packages/synapse-interface/utils/actions/approveAndDeposit.tsx on lines 230..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              try {
    segmentAnalyticsEvent(
      `[Empty Pool Deposit] Attempt`,
      {
        poolName: pool?.name,
            Severity: Major
            Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx and 1 other location - About 2 hrs to fix
            packages/synapse-interface/utils/actions/approveAndDeposit.tsx on lines 129..210

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const successToastContent = (
      <div>
        <div>
          <TranslatedText namespace="Pools" id="Liquidity added" />
        </div>
            Severity: Major
            Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx and 1 other location - About 2 hrs to fix
            packages/synapse-interface/utils/actions/approveAndDeposit.tsx on lines 178..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const successToastContent = (
      <div>
        <div>
          <TranslatedText namespace="Pools" id="Liquidity added" />
        </div>
            Severity: Major
            Found in packages/synapse-interface/utils/actions/approveAndDeposit.tsx and 1 other location - About 2 hrs to fix
            packages/synapse-interface/utils/actions/approveAndDeposit.tsx on lines 266..276

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status