Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/cctp-relayer/relayer/synapse.go

Summary

Maintainability
C
1 day
Test Coverage

Method synapseCCTPHandler.FetchAndProcessSentEvent has 81 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (s *synapseCCTPHandler) FetchAndProcessSentEvent(parentCtx context.Context, txhash common.Hash, originChain uint32) (msg *relayTypes.Message, err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "FetchAndProcessSentEvent", trace.WithAttributes(
        attribute.String(metrics.TxHash, txhash.String()),
        attribute.Int(metrics.ChainID, int(originChain)),
    ))
Severity: Major
Found in services/cctp-relayer/relayer/synapse.go - About 2 hrs to fix

    Method synapseCCTPHandler.FetchAndProcessSentEvent has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func (s *synapseCCTPHandler) FetchAndProcessSentEvent(parentCtx context.Context, txhash common.Hash, originChain uint32) (msg *relayTypes.Message, err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "FetchAndProcessSentEvent", trace.WithAttributes(
        attribute.String(metrics.TxHash, txhash.String()),
        attribute.Int(metrics.ChainID, int(originChain)),
    ))
    Severity: Minor
    Found in services/cctp-relayer/relayer/synapse.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method synapseCCTPHandler.FetchAndProcessSentEvent has 13 return statements (exceeds 4 allowed).
    Open

    func (s *synapseCCTPHandler) FetchAndProcessSentEvent(parentCtx context.Context, txhash common.Hash, originChain uint32) (msg *relayTypes.Message, err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "FetchAndProcessSentEvent", trace.WithAttributes(
        attribute.String(metrics.TxHash, txhash.String()),
        attribute.Int(metrics.ChainID, int(originChain)),
    ))
    Severity: Major
    Found in services/cctp-relayer/relayer/synapse.go - About 1 hr to fix

      Method synapseCCTPHandler.SubmitReceiveMessage has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (s *synapseCCTPHandler) SubmitReceiveMessage(parentCtx context.Context, msg *relayTypes.Message) (err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "SubmitReceiveMessage", trace.WithAttributes(
        attribute.String(MessageHash, msg.MessageHash),
        attribute.Int(metrics.Origin, int(msg.OriginChainID)),
        attribute.Int(metrics.Destination, int(msg.DestChainID)),
      Severity: Minor
      Found in services/cctp-relayer/relayer/synapse.go - About 1 hr to fix

        Method synapseCCTPHandler.SubmitReceiveMessage has 10 return statements (exceeds 4 allowed).
        Open

        func (s *synapseCCTPHandler) SubmitReceiveMessage(parentCtx context.Context, msg *relayTypes.Message) (err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "SubmitReceiveMessage", trace.WithAttributes(
        attribute.String(MessageHash, msg.MessageHash),
        attribute.Int(metrics.Origin, int(msg.OriginChainID)),
        attribute.Int(metrics.Destination, int(msg.DestChainID)),
        Severity: Major
        Found in services/cctp-relayer/relayer/synapse.go - About 1 hr to fix

          Method synapseCCTPHandler.HandleLog has 7 return statements (exceeds 4 allowed).
          Open

          func (s *synapseCCTPHandler) HandleLog(ctx context.Context, log *types.Log, chainID uint32) (processQueue bool, err error) {
    if log == nil {
        return false, fmt.Errorf("log is nil")
    }
          Severity: Major
          Found in services/cctp-relayer/relayer/synapse.go - About 45 mins to fix

            Method synapseCCTPHandler.handleCircleRequestFulfilled has 7 return statements (exceeds 4 allowed).
            Open

            func (s *synapseCCTPHandler) handleCircleRequestFulfilled(parentCtx context.Context, log *types.Log, destChain uint32) (err error) {
    ctx, span := s.handler.Tracer().Start(parentCtx, "handleCircleRequestFulfilled", trace.WithAttributes(
        attribute.String(metrics.TxHash, log.TxHash.String()),
        attribute.Int(metrics.Destination, int(destChain)),
    ))
            Severity: Major
            Found in services/cctp-relayer/relayer/synapse.go - About 45 mins to fix

              Function NewSynapseCCTPHandler has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func NewSynapseCCTPHandler(ctx context.Context, cfg config.Config, db db2.CCTPRelayerDB, omniRPCClient omniClient.RPCClient, txSubmitter submitter.TransactionSubmitter, handler metrics.Handler) (_ CCTPHandler, err error) {
              Severity: Minor
              Found in services/cctp-relayer/relayer/synapse.go - About 45 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    ctx, span := s.handler.Tracer().Start(parentCtx, "SubmitReceiveMessage", trace.WithAttributes(
        attribute.String(MessageHash, msg.MessageHash),
        attribute.Int(metrics.Origin, int(msg.OriginChainID)),
        attribute.Int(metrics.Destination, int(msg.DestChainID)),
        attribute.String(metrics.TxHash, msg.OriginTxHash),
                Severity: Minor
                Found in services/cctp-relayer/relayer/synapse.go and 2 other locations - About 40 mins to fix
                services/cctp-relayer/relayer/relayer.go on lines 254..259
                services/cctp-relayer/relayer/relayer.go on lines 378..383

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 109.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status