Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/explorer/consumer/fetcher/pricefetcher.go

Summary

Maintainability
B
6 hrs
Test Coverage

Function GetDefiLlamaData has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

func GetDefiLlamaData(ctx context.Context, timestamp int, coinGeckoID string) *float64 {
    zero := float64(0)

    if coinGeckoID == "NO_TOKEN" || coinGeckoID == "NO_PRICE" {
        // if there is no data on the token, the amount returned will be 1:1 (price will be same as the amount of token
Severity: Minor
Found in services/explorer/consumer/fetcher/pricefetcher.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function GetDefiLlamaData has 85 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func GetDefiLlamaData(ctx context.Context, timestamp int, coinGeckoID string) *float64 {
    zero := float64(0)

    if coinGeckoID == "NO_TOKEN" || coinGeckoID == "NO_PRICE" {
        // if there is no data on the token, the amount returned will be 1:1 (price will be same as the amount of token
Severity: Major
Found in services/explorer/consumer/fetcher/pricefetcher.go - About 2 hrs to fix

    There are no issues that match your filters.

    Category
    Status