synapsecns/sanguine

View on GitHub
services/explorer/consumer/parser/rfqparser.go

Summary

Maintainability
C
1 day
Test Coverage

Function rfqEventToBridgeEvent has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func rfqEventToBridgeEvent(rfqEvent model.RFQEvent) model.BridgeEvent {
    // Only convert BridgeRequestedEvent and BridgeRelayedEvent to bridge events
    // Exclude BridgeDepositRefunded, BridgeProofProvided, and BridgeDepositClaimed
    eventType := rfqEvent.EventType
    if eventType != rfqTypes.BridgeRequestedEvent.Int() &&
Severity: Minor
Found in services/explorer/consumer/parser/rfqparser.go - About 1 hr to fix

    Method RFQParser.ParseLog has 9 return statements (exceeds 4 allowed).
    Open

    func (p *RFQParser) ParseLog(log ethTypes.Log, chainID uint32) (*model.RFQEvent, rfqTypes.EventLog, error) {
        logTopic := log.Topics[0]
        iFace, err := func(log ethTypes.Log) (rfqTypes.EventLog, error) {
            // Get the topic hash safely
            bridgeRequestedTopic, err := fastbridge.Topic(rfqTypes.BridgeRequestedEvent)
    Severity: Major
    Found in services/explorer/consumer/parser/rfqparser.go - About 55 mins to fix

      Function NewRFQParser has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func NewRFQParser(consumerDB db.ConsumerDB, rfqAddress common.Address, consumerFetcher fetcher.ScribeFetcher, rfqService fetcher.RFQService, tokenDataService tokendata.Service, tokenPriceService tokenprice.Service, fromAPI bool) (*RFQParser, error) {
      Severity: Major
      Found in services/explorer/consumer/parser/rfqparser.go - About 50 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (p *RFQParser) storeBridgeEvent(ctx context.Context, bridgeEvent model.BridgeEvent) error {
            b := &backoff.Backoff{
                Factor: 2,
                Jitter: true,
                Min:    1 * time.Second,
        Severity: Major
        Found in services/explorer/consumer/parser/rfqparser.go and 1 other location - About 2 hrs to fix
        services/explorer/consumer/parser/cctpparser.go on lines 262..284

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 209.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func NewRFQParser(consumerDB db.ConsumerDB, rfqAddress common.Address, consumerFetcher fetcher.ScribeFetcher, rfqService fetcher.RFQService, tokenDataService tokendata.Service, tokenPriceService tokenprice.Service, fromAPI bool) (*RFQParser, error) {
            filterer, err := fastbridge.NewFastBridgeFilterer(rfqAddress, nil)
            if err != nil {
                return nil, fmt.Errorf("could not create %T: %w", fastbridge.FastBridgeFilterer{}, err)
            }
        Severity: Major
        Found in services/explorer/consumer/parser/rfqparser.go and 1 other location - About 1 hr to fix
        services/explorer/consumer/parser/cctpparser.go on lines 46..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 147.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (p *RFQParser) Parse(ctx context.Context, log ethTypes.Log, chainID uint32) (interface{}, error) {
            rfqEvent, iFace, err := p.ParseLog(log, chainID)
            if err != nil {
                return nil, fmt.Errorf("could not parse rfq event: %w", err)
            }
        Severity: Major
        Found in services/explorer/consumer/parser/rfqparser.go and 1 other location - About 1 hr to fix
        services/explorer/consumer/parser/cctpparser.go on lines 149..159

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 144.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        type RFQParser struct {
            // consumerDB is the database to store parsed data in
            consumerDB db.ConsumerDB
            // Filterer is the message Filterer we use to parse events
            Filterer *fastbridge.FastBridgeFilterer
        Severity: Minor
        Found in services/explorer/consumer/parser/rfqparser.go and 1 other location - About 45 mins to fix
        services/explorer/consumer/parser/cctpparser.go on lines 23..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 116.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status