synapsecns/sanguine

View on GitHub
services/explorer/contracts/swap/liquidity.go

Summary

Maintainability
D
2 days
Test Coverage

SwapFlashLoanRemoveLiquidity has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

func (s SwapFlashLoanRemoveLiquidity) GetRaw() ethTypes.Log {
    return s.Raw
}
Severity: Minor
Found in services/explorer/contracts/swap/liquidity.go - About 3 hrs to fix

    SwapFlashLoanRemoveLiquidityImbalance has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

    func (s SwapFlashLoanRemoveLiquidityImbalance) GetRaw() ethTypes.Log {
        return s.Raw
    }
    Severity: Minor
    Found in services/explorer/contracts/swap/liquidity.go - About 3 hrs to fix

      SwapFlashLoanRemoveLiquidityOne has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

      func (s SwapFlashLoanRemoveLiquidityOne) GetRaw() ethTypes.Log {
          return s.Raw
      }
      Severity: Minor
      Found in services/explorer/contracts/swap/liquidity.go - About 3 hrs to fix

        SwapFlashLoanAddLiquidity has 27 methods (exceeds 20 allowed). Consider refactoring.
        Open

        func (s SwapFlashLoanAddLiquidity) GetRaw() ethTypes.Log {
            return s.Raw
        }
        Severity: Minor
        Found in services/explorer/contracts/swap/liquidity.go - About 3 hrs to fix

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func (s SwapFlashLoanAddLiquidity) GetAmount() map[uint8]string {
              tokenAmounts := make(map[uint8]string)
              zero := big.NewInt(0)
              for i, tokenAmount := range s.TokenAmounts {
                  if tokenAmount.Cmp(zero) == 1 {
          Severity: Major
          Found in services/explorer/contracts/swap/liquidity.go and 4 other locations - About 50 mins to fix
          services/explorer/contracts/swap/liquidity.go on lines 60..69
          services/explorer/contracts/swap/liquidity.go on lines 193..202
          services/explorer/contracts/swap/liquidity.go on lines 473..482
          services/explorer/contracts/swap/liquidity.go on lines 485..494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func (s SwapFlashLoanRemoveLiquidityImbalance) GetAmountFee() map[uint8]string {
              feeAmounts := make(map[uint8]string)
              zero := big.NewInt(0)
              for i, feeAmount := range s.Fees {
                  if feeAmount.Cmp(zero) == 1 {
          Severity: Major
          Found in services/explorer/contracts/swap/liquidity.go and 4 other locations - About 50 mins to fix
          services/explorer/contracts/swap/liquidity.go on lines 48..57
          services/explorer/contracts/swap/liquidity.go on lines 60..69
          services/explorer/contracts/swap/liquidity.go on lines 193..202
          services/explorer/contracts/swap/liquidity.go on lines 473..482

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func (s SwapFlashLoanAddLiquidity) GetAmountFee() map[uint8]string {
              feeAmounts := make(map[uint8]string)
              zero := big.NewInt(0)
              for i, feeAmount := range s.Fees {
                  if feeAmount.Cmp(zero) == 1 {
          Severity: Major
          Found in services/explorer/contracts/swap/liquidity.go and 4 other locations - About 50 mins to fix
          services/explorer/contracts/swap/liquidity.go on lines 48..57
          services/explorer/contracts/swap/liquidity.go on lines 193..202
          services/explorer/contracts/swap/liquidity.go on lines 473..482
          services/explorer/contracts/swap/liquidity.go on lines 485..494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func (s SwapFlashLoanRemoveLiquidityImbalance) GetAmount() map[uint8]string {
              tokenAmounts := make(map[uint8]string)
              zero := big.NewInt(0)
              for i, tokenAmount := range s.TokenAmounts {
                  if tokenAmount.Cmp(zero) == 1 {
          Severity: Major
          Found in services/explorer/contracts/swap/liquidity.go and 4 other locations - About 50 mins to fix
          services/explorer/contracts/swap/liquidity.go on lines 48..57
          services/explorer/contracts/swap/liquidity.go on lines 60..69
          services/explorer/contracts/swap/liquidity.go on lines 193..202
          services/explorer/contracts/swap/liquidity.go on lines 485..494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

          func (s SwapFlashLoanRemoveLiquidity) GetAmount() map[uint8]string {
              tokenAmounts := make(map[uint8]string)
              zero := big.NewInt(0)
              for i, tokenAmount := range s.TokenAmounts {
                  if tokenAmount.Cmp(zero) == 1 {
          Severity: Major
          Found in services/explorer/contracts/swap/liquidity.go and 4 other locations - About 50 mins to fix
          services/explorer/contracts/swap/liquidity.go on lines 48..57
          services/explorer/contracts/swap/liquidity.go on lines 60..69
          services/explorer/contracts/swap/liquidity.go on lines 473..482
          services/explorer/contracts/swap/liquidity.go on lines 485..494

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status