Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/explorer/graphql/server/graph/fetcher.go

Summary

Maintainability
D
2 days
Test Coverage

Method Resolver.getAndParseLogs has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

func (r Resolver) getAndParseLogs(ctx context.Context, logFetcher *indexer.LogFetcher, chainID uint32, kappa string, bridgeType model.BridgeType) (interface{}, error) {
    streamLogsCtx, cancelStreamLogs := context.WithCancel(ctx)
    logsChan := *logFetcher.GetFetchedLogsChan()
    destinationData := make(chan *ifaceBridgeEvent, 1)
    destinationDataCCTP := make(chan *ifaceCCTPEvent, 1)
Severity: Minor
Found in services/explorer/graphql/server/graph/fetcher.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Resolver.bwDestinationFallback has 85 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r Resolver) bwDestinationFallback(ctx context.Context, chainID uint32, address string, identifier string, timestamp int, historical bool, bridgeType model.BridgeType) (*model.BridgeWatcherTx, error) {
    txFetchContext, cancelTxFetch := context.WithTimeout(ctx, maxTimeToWaitForTx)
    defer cancelTxFetch()

    b := &backoff.Backoff{
Severity: Major
Found in services/explorer/graphql/server/graph/fetcher.go - About 2 hrs to fix

    Method Resolver.getAndParseLogs has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r Resolver) getAndParseLogs(ctx context.Context, logFetcher *indexer.LogFetcher, chainID uint32, kappa string, bridgeType model.BridgeType) (interface{}, error) {
    streamLogsCtx, cancelStreamLogs := context.WithCancel(ctx)
    logsChan := *logFetcher.GetFetchedLogsChan()
    destinationData := make(chan *ifaceBridgeEvent, 1)
    destinationDataCCTP := make(chan *ifaceCCTPEvent, 1)
    Severity: Major
    Found in services/explorer/graphql/server/graph/fetcher.go - About 2 hrs to fix

      Method Resolver.bwDestinationFallback has a Cognitive Complexity of 32 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r Resolver) bwDestinationFallback(ctx context.Context, chainID uint32, address string, identifier string, timestamp int, historical bool, bridgeType model.BridgeType) (*model.BridgeWatcherTx, error) {
    txFetchContext, cancelTxFetch := context.WithTimeout(ctx, maxTimeToWaitForTx)
    defer cancelTxFetch()

    b := &backoff.Backoff{
      Severity: Minor
      Found in services/explorer/graphql/server/graph/fetcher.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Resolver.bwOriginFallback has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
      Open

      func (r Resolver) bwOriginFallback(ctx context.Context, chainID uint32, txHash string) (*model.BridgeWatcherTx, error) {
    txFetchContext, cancelTxFetch := context.WithTimeout(ctx, maxTimeToWaitForTx)
    defer cancelTxFetch()
    b := &backoff.Backoff{
        Factor: 2,
      Severity: Minor
      Found in services/explorer/graphql/server/graph/fetcher.go - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method Resolver.getAndParseLogs has 9 return statements (exceeds 4 allowed).
      Open

      func (r Resolver) getAndParseLogs(ctx context.Context, logFetcher *indexer.LogFetcher, chainID uint32, kappa string, bridgeType model.BridgeType) (interface{}, error) {
    streamLogsCtx, cancelStreamLogs := context.WithCancel(ctx)
    logsChan := *logFetcher.GetFetchedLogsChan()
    destinationData := make(chan *ifaceBridgeEvent, 1)
    destinationDataCCTP := make(chan *ifaceCCTPEvent, 1)
      Severity: Major
      Found in services/explorer/graphql/server/graph/fetcher.go - About 55 mins to fix

        Method Resolver.bwDestinationFallback has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func (r Resolver) bwDestinationFallback(ctx context.Context, chainID uint32, address string, identifier string, timestamp int, historical bool, bridgeType model.BridgeType) (*model.BridgeWatcherTx, error) {
        Severity: Major
        Found in services/explorer/graphql/server/graph/fetcher.go - About 50 mins to fix

          Method Resolver.bwDestinationFallback has 6 return statements (exceeds 4 allowed).
          Open

          func (r Resolver) bwDestinationFallback(ctx context.Context, chainID uint32, address string, identifier string, timestamp int, historical bool, bridgeType model.BridgeType) (*model.BridgeWatcherTx, error) {
    txFetchContext, cancelTxFetch := context.WithTimeout(ctx, maxTimeToWaitForTx)
    defer cancelTxFetch()

    b := &backoff.Backoff{
          Severity: Major
          Found in services/explorer/graphql/server/graph/fetcher.go - About 40 mins to fix

            Method Resolver.getAndParseLogs has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (r Resolver) getAndParseLogs(ctx context.Context, logFetcher *indexer.LogFetcher, chainID uint32, kappa string, bridgeType model.BridgeType) (interface{}, error) {
            Severity: Minor
            Found in services/explorer/graphql/server/graph/fetcher.go - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (r Resolver) checkRequestIDExists(ctx context.Context, requestID string, chainID uint32) bool {
    var kappaBytes32 [32]byte
    kappaBytes := common.Hex2Bytes(requestID)
    copy(kappaBytes32[:], kappaBytes)
    exists, err := r.Refs.CCTPRefs[chainID].IsRequestFulfilled(&bind.CallOpts{
              Severity: Major
              Found in services/explorer/graphql/server/graph/fetcher.go and 1 other location - About 1 hr to fix
              services/explorer/graphql/server/graph/fetcher.go on lines 461..475

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 150.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func (r Resolver) checkKappaExists(ctx context.Context, kappa string, chainID uint32) bool {
    var kappaBytes32 [32]byte

    kappaBytes := common.Hex2Bytes(kappa)
    copy(kappaBytes32[:], kappaBytes)
              Severity: Major
              Found in services/explorer/graphql/server/graph/fetcher.go and 1 other location - About 1 hr to fix
              services/explorer/graphql/server/graph/fetcher.go on lines 477..489

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 150.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status