synapsecns/sanguine

View on GitHub
services/explorer/graphql/server/graph/queries.resolvers.go

Summary

Maintainability
D
2 days
Test Coverage

Method queryResolver.BridgeTransactions has 19 arguments (exceeds 4 allowed). Consider refactoring.
Open

func (r *queryResolver) BridgeTransactions(ctx context.Context, chainIDFrom []*int, chainIDTo []*int, addressFrom *string, addressTo *string, maxAmount *int, minAmount *int, maxAmountUsd *int, minAmountUsd *int, startTime *int, endTime *int, txnHash *string, kappa *string, pending *bool, useMv *bool, page *int, tokenAddressFrom []*string, tokenAddressTo []*string, onlyCctp *bool) ([]*model.BridgeTransaction, error) {
Severity: Major
Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 2 hrs to fix

    Method queryResolver.AddressData has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *queryResolver) AddressData(ctx context.Context, address string) (*model.AddressData, error) {
        bridgeQuery := fmt.Sprintf("SELECT toFloat64(sumKahan(famount_usd)) AS volumeTotal, toFloat64(sumKahan(tfee_amount_usd)) AS feeTotal, toInt64(uniq(fchain_id, ftx_hash)) AS txTotal FROM (SELECT * FROM mv_bridge_events where fsender = '%s' LIMIT 1 BY fchain_id,fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash)", address)
        swapQuery := fmt.Sprintf("SELECT toFloat64(sumKahan(multiIf(event_type = 0, amount_usd[sold_id], event_type = 1, arraySum(mapValues(amount_usd)), event_type = 9, arraySum(mapValues(amount_usd)), event_type = 10, amount_usd[sold_id],0))) AS volumeTotal, toFloat64(sumKahan(arraySum(mapValues(fee_usd)))) AS feeTotal,  toInt64(uniq(chain_id, tx_hash)) AS txTotal FROM (SELECT * FROM swap_events where sender = '%s' LIMIT 1 BY chain_id, contract_address, event_type, block_number, event_index, tx_hash)", address)
        rankingQuery := fmt.Sprintf("select rowNumber from (select sender, row_number() over (order by sumTotal desc ) as rowNumber from (select fsender as sender, sumKahan(famount_usd) as sumTotal from (SELECT * FROM mv_bridge_events where fsender != '' LIMIT 1 BY fchain_id, fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash) where fsender != '' group by fsender)) where sender = '%s'", address)
        firstTx := fmt.Sprintf("SELECT min(ftimestamp) AS earliestTime FROM (SELECT * FROM mv_bridge_events where fsender = '%s' LIMIT 1 BY fchain_id,fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash)", address)
    Severity: Major
    Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 2 hrs to fix

      Method queryResolver.AmountStatistic has 68 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (r *queryResolver) AmountStatistic(ctx context.Context, typeArg model.StatisticType, duration *model.Duration, platform *model.Platform, chainID *int, address *string, tokenAddress *string, useCache *bool, useMv *bool) (*model.ValueResult, error) {
          if useCache != nil && *useCache {
              res, err := r.getValueResultFromCache(fmt.Sprintf("amountStatistic, %s, %s, %s, %s, %s, %s", typeArg.String(), platform.String(), duration.String(), keyGenHandleNilInt(chainID), keyGenHandleNilString(address), keyGenHandleNilString(tokenAddress)))
              if err == nil {
                  return res, nil
      Severity: Minor
      Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

        Method queryResolver.DailyStatisticsByChain has 64 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (r *queryResolver) DailyStatisticsByChain(ctx context.Context, chainID *int, typeArg *model.DailyStatisticType, platform *model.Platform, duration *model.Duration, useCache *bool, useMv *bool) ([]*model.DateResultByChain, error) {
            cacheKey := fmt.Sprintf("dailyStatisticsByChain, %s, %s, %s, %s", keyGenHandleNilInt(chainID), typeArg.String(), duration.String(), platform.String())
        
            if useCache != nil && *useCache {
                locker := r.CacheMutex.Lock(cacheKey)
        Severity: Minor
        Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

          Method queryResolver.AddressData has 14 return statements (exceeds 4 allowed).
          Open

          func (r *queryResolver) AddressData(ctx context.Context, address string) (*model.AddressData, error) {
              bridgeQuery := fmt.Sprintf("SELECT toFloat64(sumKahan(famount_usd)) AS volumeTotal, toFloat64(sumKahan(tfee_amount_usd)) AS feeTotal, toInt64(uniq(fchain_id, ftx_hash)) AS txTotal FROM (SELECT * FROM mv_bridge_events where fsender = '%s' LIMIT 1 BY fchain_id,fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash)", address)
              swapQuery := fmt.Sprintf("SELECT toFloat64(sumKahan(multiIf(event_type = 0, amount_usd[sold_id], event_type = 1, arraySum(mapValues(amount_usd)), event_type = 9, arraySum(mapValues(amount_usd)), event_type = 10, amount_usd[sold_id],0))) AS volumeTotal, toFloat64(sumKahan(arraySum(mapValues(fee_usd)))) AS feeTotal,  toInt64(uniq(chain_id, tx_hash)) AS txTotal FROM (SELECT * FROM swap_events where sender = '%s' LIMIT 1 BY chain_id, contract_address, event_type, block_number, event_index, tx_hash)", address)
              rankingQuery := fmt.Sprintf("select rowNumber from (select sender, row_number() over (order by sumTotal desc ) as rowNumber from (select fsender as sender, sumKahan(famount_usd) as sumTotal from (SELECT * FROM mv_bridge_events where fsender != '' LIMIT 1 BY fchain_id, fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash) where fsender != '' group by fsender)) where sender = '%s'", address)
              firstTx := fmt.Sprintf("SELECT min(ftimestamp) AS earliestTime FROM (SELECT * FROM mv_bridge_events where fsender = '%s' LIMIT 1 BY fchain_id,fcontract_address, fevent_type, fblock_number, fevent_index, ftx_hash)", address)
          Severity: Major
          Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

            Method queryResolver.MessageBusTransactions has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (r *queryResolver) MessageBusTransactions(ctx context.Context, chainID []*int, contractAddress *string, startTime *int, endTime *int, txnHash *string, messageID *string, pending *bool, reverted *bool, page *int) ([]*model.MessageBusTransaction, error) {
            Severity: Major
            Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

              Method queryResolver.AmountStatistic has 12 return statements (exceeds 4 allowed).
              Open

              func (r *queryResolver) AmountStatistic(ctx context.Context, typeArg model.StatisticType, duration *model.Duration, platform *model.Platform, chainID *int, address *string, tokenAddress *string, useCache *bool, useMv *bool) (*model.ValueResult, error) {
                  if useCache != nil && *useCache {
                      res, err := r.getValueResultFromCache(fmt.Sprintf("amountStatistic, %s, %s, %s, %s, %s, %s", typeArg.String(), platform.String(), duration.String(), keyGenHandleNilInt(chainID), keyGenHandleNilString(address), keyGenHandleNilString(tokenAddress)))
                      if err == nil {
                          return res, nil
              Severity: Major
              Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

                Method queryResolver.AmountStatistic has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (r *queryResolver) AmountStatistic(ctx context.Context, typeArg model.StatisticType, duration *model.Duration, platform *model.Platform, chainID *int, address *string, tokenAddress *string, useCache *bool, useMv *bool) (*model.ValueResult, error) {
                Severity: Major
                Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

                  Method queryResolver.DailyStatisticsByChain has 11 return statements (exceeds 4 allowed).
                  Open

                  func (r *queryResolver) DailyStatisticsByChain(ctx context.Context, chainID *int, typeArg *model.DailyStatisticType, platform *model.Platform, duration *model.Duration, useCache *bool, useMv *bool) ([]*model.DateResultByChain, error) {
                      cacheKey := fmt.Sprintf("dailyStatisticsByChain, %s, %s, %s, %s", keyGenHandleNilInt(chainID), typeArg.String(), duration.String(), platform.String())
                  
                      if useCache != nil && *useCache {
                          locker := r.CacheMutex.Lock(cacheKey)
                  Severity: Major
                  Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 1 hr to fix

                    Method queryResolver.DailyStatisticsByChain has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (r *queryResolver) DailyStatisticsByChain(ctx context.Context, chainID *int, typeArg *model.DailyStatisticType, platform *model.Platform, duration *model.Duration, useCache *bool, useMv *bool) ([]*model.DateResultByChain, error) {
                    Severity: Major
                    Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 50 mins to fix

                      Method queryResolver.GetDestinationBridgeTx has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func (r *queryResolver) GetDestinationBridgeTx(ctx context.Context, chainID int, address string, kappa string, timestamp int, bridgeType model.BridgeType, historical *bool) (*model.BridgeWatcherTx, error) {
                      Severity: Major
                      Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 50 mins to fix

                        Method queryResolver.Leaderboard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func (r *queryResolver) Leaderboard(ctx context.Context, duration *model.Duration, chainID *int, useMv *bool, page *int) ([]*model.Leaderboard, error) {
                        Severity: Minor
                        Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 35 mins to fix

                          Method queryResolver.CountByTokenAddress has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          func (r *queryResolver) CountByTokenAddress(ctx context.Context, chainID *int, address *string, direction *model.Direction, hours *int) ([]*model.TokenCountResult, error) {
                          Severity: Minor
                          Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 35 mins to fix

                            Method queryResolver.CountByChainID has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func (r *queryResolver) CountByChainID(ctx context.Context, chainID *int, address *string, direction *model.Direction, hours *int) ([]*model.TransactionCountResult, error) {
                            Severity: Minor
                            Found in services/explorer/graphql/server/graph/queries.resolvers.go - About 35 mins to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                              func (r *queryResolver) BridgeTransactions(ctx context.Context, chainIDFrom []*int, chainIDTo []*int, addressFrom *string, addressTo *string, maxAmount *int, minAmount *int, maxAmountUsd *int, minAmountUsd *int, startTime *int, endTime *int, txnHash *string, kappa *string, pending *bool, useMv *bool, page *int, tokenAddressFrom []*string, tokenAddressTo []*string, onlyCctp *bool) ([]*model.BridgeTransaction, error) {
                                  var results []*model.BridgeTransaction
                                  if useMv != nil && *useMv {
                                      var mvResults []*model.BridgeTransaction
                                      var err error
                              Severity: Major
                              Found in services/explorer/graphql/server/graph/queries.resolvers.go and 1 other location - About 1 hr to fix
                              services/explorer/graphql/server/graph/resolver/server.go on lines 244..244

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 165.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              func (r *queryResolver) CountByChainID(ctx context.Context, chainID *int, address *string, direction *model.Direction, hours *int) ([]*model.TransactionCountResult, error) {
                                  directionIn := r.getDirectionIn(direction)
                                  targetTime := GetTargetTime(hours)
                                  results, err := r.DB.GetTxCounts(ctx, generateBridgeEventCountQuery(chainID, address, nil, directionIn, &targetTime, false))
                                  if err != nil {
                              Severity: Major
                              Found in services/explorer/graphql/server/graph/queries.resolvers.go and 1 other location - About 1 hr to fix
                              services/explorer/graphql/server/graph/queries.resolvers.go on lines 83..93

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 162.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                              func (r *queryResolver) CountByTokenAddress(ctx context.Context, chainID *int, address *string, direction *model.Direction, hours *int) ([]*model.TokenCountResult, error) {
                                  directionIn := r.getDirectionIn(direction)
                                  targetTime := GetTargetTime(hours)
                                  results, err := r.DB.GetTokenCounts(ctx, generateBridgeEventCountQuery(chainID, address, nil, directionIn, &targetTime, true))
                              
                              
                              Severity: Major
                              Found in services/explorer/graphql/server/graph/queries.resolvers.go and 1 other location - About 1 hr to fix
                              services/explorer/graphql/server/graph/queries.resolvers.go on lines 72..80

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 162.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status