Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/explorer/node/explorer.go

Summary

Maintainability
C
1 day
Test Coverage

Function getChainBackfiller has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func getChainBackfiller(consumerDB db.ConsumerDB, chainConfig indexerConfig.ChainConfig, fetcher fetcherpkg.ScribeFetcher, client bind.ContractBackend, tokenDataService tokendata.Service, priceDataService tokenprice.Service) (*backfill.ChainBackfiller, error) {
    var err error
    var bridgeParser *parser.BridgeParser
    var messageBusParser *parser.MessageBusParser
    var cctpParser *parser.CCTPParser
Severity: Minor
Found in services/explorer/node/explorer.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getChainBackfiller has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func getChainBackfiller(consumerDB db.ConsumerDB, chainConfig indexerConfig.ChainConfig, fetcher fetcherpkg.ScribeFetcher, client bind.ContractBackend, tokenDataService tokendata.Service, priceDataService tokenprice.Service) (*backfill.ChainBackfiller, error) {
    var err error
    var bridgeParser *parser.BridgeParser
    var messageBusParser *parser.MessageBusParser
    var cctpParser *parser.CCTPParser
Severity: Minor
Found in services/explorer/node/explorer.go - About 1 hr to fix

    Function getChainBackfiller has 11 return statements (exceeds 4 allowed).
    Open

    func getChainBackfiller(consumerDB db.ConsumerDB, chainConfig indexerConfig.ChainConfig, fetcher fetcherpkg.ScribeFetcher, client bind.ContractBackend, tokenDataService tokendata.Service, priceDataService tokenprice.Service) (*backfill.ChainBackfiller, error) {
    var err error
    var bridgeParser *parser.BridgeParser
    var messageBusParser *parser.MessageBusParser
    var cctpParser *parser.CCTPParser
    Severity: Major
    Found in services/explorer/node/explorer.go - About 1 hr to fix

      Function NewExplorerBackfiller has 7 return statements (exceeds 4 allowed).
      Open

      func NewExplorerBackfiller(consumerDB db.ConsumerDB, config indexerConfig.Config, clients map[uint32]bind.ContractBackend, handler metrics.Handler) (*ExplorerBackfiller, error) {
    chainBackfillers := make(map[uint32]*backfill.ChainBackfiller)
    httpClient := http.Client{
        Timeout: 10 * time.Second,
        Transport: &http.Transport{
      Severity: Major
      Found in services/explorer/node/explorer.go - About 45 mins to fix

        Function getChainBackfiller has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func getChainBackfiller(consumerDB db.ConsumerDB, chainConfig indexerConfig.ChainConfig, fetcher fetcherpkg.ScribeFetcher, client bind.ContractBackend, tokenDataService tokendata.Service, priceDataService tokenprice.Service) (*backfill.ChainBackfiller, error) {
        Severity: Minor
        Found in services/explorer/node/explorer.go - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  case "rfq":
            rfqService, err = fetcherpkg.NewRFQFetcher(common.HexToAddress(chainConfig.Contracts[i].Address), client)
            if err != nil || rfqService == nil {
                return nil, fmt.Errorf("could not create rfqService: %w", err)
            }
          Severity: Major
          Found in services/explorer/node/explorer.go and 1 other location - About 1 hr to fix
          services/explorer/node/explorer.go on lines 172..180

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  case "cctp":
            cctpService, err = fetcherpkg.NewCCTPFetcher(common.HexToAddress(chainConfig.Contracts[i].Address), client)
            if err != nil || cctpService == nil {
                return nil, fmt.Errorf("could not create cctpService: %w", err)
            }
          Severity: Major
          Found in services/explorer/node/explorer.go and 1 other location - About 1 hr to fix
          services/explorer/node/explorer.go on lines 181..189

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 141.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status