Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/omnirpc/modules/harmonyproxy/harmonyproxy.go

Summary

Maintainability
D
2 days
Test Coverage

Method HarmonyProxy.getHarmonyReceiptVerify has 90 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *HarmonyProxy) getHarmonyReceiptVerify(parentCtx context.Context, txHash common.Hash, rawBody []byte, checkVersion bool) (_ []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getHarmonyReceiptVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
Severity: Major
Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 2 hrs to fix

    Method HarmonyProxy.getLogsHarmonyVerify has 89 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (r *HarmonyProxy) getLogsHarmonyVerify(parentCtx context.Context, query ethereum.FilterQuery, rawBody []byte) (rawResp []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getLogsHarmonyVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
    Severity: Major
    Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 2 hrs to fix

      Method HarmonyProxy.getHarmonyReceiptVerify has 22 return statements (exceeds 4 allowed).
      Open

      func (r *HarmonyProxy) getHarmonyReceiptVerify(parentCtx context.Context, txHash common.Hash, rawBody []byte, checkVersion bool) (_ []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getHarmonyReceiptVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
      Severity: Major
      Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 2 hrs to fix

        Method HarmonyProxy.getHarmonyReceiptVerify has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func (r *HarmonyProxy) getHarmonyReceiptVerify(parentCtx context.Context, txHash common.Hash, rawBody []byte, checkVersion bool) (_ []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getHarmonyReceiptVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
        Severity: Minor
        Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method HarmonyProxy.getLogsHarmonyVerify has 17 return statements (exceeds 4 allowed).
        Open

        func (r *HarmonyProxy) getLogsHarmonyVerify(parentCtx context.Context, query ethereum.FilterQuery, rawBody []byte) (rawResp []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getLogsHarmonyVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
        Severity: Major
        Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 1 hr to fix

          Method HarmonyProxy.getLogsHarmonyVerify has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring.
          Open

          func (r *HarmonyProxy) getLogsHarmonyVerify(parentCtx context.Context, query ethereum.FilterQuery, rawBody []byte) (rawResp []byte, err error) {
    ctx, span := r.tracer.Start(parentCtx, "getLogsHarmonyVerify")

    defer func() {
        metrics.EndSpanWithErr(span, err)
          Severity: Minor
          Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function filterLogs has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
          Open

          func filterLogs(logs []*types.Log, fromBlock, toBlock *big.Int, addresses []common.Address, topics [][]common.Hash) []*types.Log {
    var ret []*types.Log
Logs:
    for _, currentLog := range logs {
        if fromBlock != nil && fromBlock.Int64() >= 0 && fromBlock.Uint64() > currentLog.BlockNumber {
          Severity: Minor
          Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method HarmonyProxy.verifyHarmonyRequest has 9 return statements (exceeds 4 allowed).
          Open

          func (r *HarmonyProxy) verifyHarmonyRequest(ctx context.Context, req rpc.Request, rawBody []byte) (willHandle bool, resp []byte, err error) {
    // nolint: exhaustive
    switch client.RPCMethod(req.Method) {
    case client.GetLogsMethod:
        if len(req.Params) != 1 {
          Severity: Major
          Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 55 mins to fix

            Method HarmonyProxy.ProxyRequest has 8 return statements (exceeds 4 allowed).
            Open

            func (r *HarmonyProxy) ProxyRequest(c *gin.Context) (err error) {
    ctx, span := r.tracer.Start(c, "ProxyRequest",
        trace.WithAttributes(attribute.String("endpoint", r.proxyURL)),
    )
            Severity: Major
            Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go - About 50 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  g.Go(func() error {
        rawResp, err = r.makeReq(ctx, rawBody)
        if err != nil {
            return fmt.Errorf("could not make req: %w", err)
        }
              Severity: Major
              Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go and 1 other location - About 1 hr to fix
              services/omnirpc/modules/harmonyproxy/harmonyproxy.go on lines 290..306

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  g.Go(func() error {
        rawResp, err = r.makeReq(ctx, rawBody)
        if err != nil {
            return fmt.Errorf("could not make req: %w", err)
        }
              Severity: Major
              Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go and 1 other location - About 1 hr to fix
              services/omnirpc/modules/harmonyproxy/harmonyproxy.go on lines 395..412

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 144.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  resp, err := req.
        SetContext(ctx).
        SetRequestURI(r.proxyURL).
        SetBody(body).
        SetHeaderBytes(omniHTTP.XRequestID, requestID).
              Severity: Major
              Found in services/omnirpc/modules/harmonyproxy/harmonyproxy.go and 4 other locations - About 40 mins to fix
              services/omnirpc/modules/confirmedtofinalized/finalizedproxy.go on lines 148..156
              services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 162..170
              services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 173..181
              services/omnirpc/modules/receiptsbackup/receiptsbackup.go on lines 188..196

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 110.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status