Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/omnirpc/proxy/standardize.go

Summary

Maintainability
C
1 day
Test Coverage

Function standardizeResponse has a Cognitive Complexity of 56 (exceeds 20 allowed). Consider refactoring.
Open

func standardizeResponse(ctx context.Context, req *rpc.Request, rpcMessage JSONRPCMessage) (out []byte, err error) {
    // TODO: use a sync.pool for acquiring/releasing these structs
    method := req.Method

OUTER:
Severity: Minor
Found in services/omnirpc/proxy/standardize.go - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function standardizeResponse has 131 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func standardizeResponse(ctx context.Context, req *rpc.Request, rpcMessage JSONRPCMessage) (out []byte, err error) {
    // TODO: use a sync.pool for acquiring/releasing these structs
    method := req.Method

OUTER:
Severity: Major
Found in services/omnirpc/proxy/standardize.go - About 4 hrs to fix

    Function standardizeResponse has 24 return statements (exceeds 4 allowed).
    Open

    func standardizeResponse(ctx context.Context, req *rpc.Request, rpcMessage JSONRPCMessage) (out []byte, err error) {
    // TODO: use a sync.pool for acquiring/releasing these structs
    method := req.Method

OUTER:
    Severity: Major
    Found in services/omnirpc/proxy/standardize.go - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status