Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/rfq/guard/service/guard.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function NewGuard has 59 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewGuard(ctx context.Context, metricHandler metrics.Handler, cfg guardconfig.Config, txSubmitter submitter.TransactionSubmitter) (*Guard, error) {
    omniClient := omniClient.NewOmnirpcClient(cfg.OmniRPCURL, metricHandler, omniClient.WithCaptureReqRes())
    chainListeners := make(map[int]listener.ContractListener)

    dbType, err := dbcommon.DBTypeFromString(cfg.Database.Type)
Severity: Minor
Found in services/rfq/guard/service/guard.go - About 1 hr to fix

    Function NewGuard has 11 return statements (exceeds 4 allowed).
    Open

    func NewGuard(ctx context.Context, metricHandler metrics.Handler, cfg guardconfig.Config, txSubmitter submitter.TransactionSubmitter) (*Guard, error) {
    omniClient := omniClient.NewOmnirpcClient(cfg.OmniRPCURL, metricHandler, omniClient.WithCaptureReqRes())
    chainListeners := make(map[int]listener.ContractListener)

    dbType, err := dbcommon.DBTypeFromString(cfg.Database.Type)
    Severity: Major
    Found in services/rfq/guard/service/guard.go - About 1 hr to fix

      Method Guard.Start has 8 return statements (exceeds 4 allowed).
      Open

      func (g *Guard) Start(ctx context.Context) (err error) {
    group, ctx := errgroup.WithContext(ctx)
    group.Go(func() error {
        err := g.startChainIndexers(ctx)
        if err != nil {
      Severity: Major
      Found in services/rfq/guard/service/guard.go - About 50 mins to fix

        Method Guard.runChainIndexer has 8 return statements (exceeds 4 allowed).
        Open

        func (g Guard) runChainIndexer(ctx context.Context, chainID int) (err error) {
    chainListener := g.chainListeners[chainID]

    parser, err := fastbridge.NewParser(chainListener.Address())
    if err != nil {
        Severity: Major
        Found in services/rfq/guard/service/guard.go - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  ctx, span := g.metrics.Tracer().Start(parentCtx, fmt.Sprintf("handleLog-%s", et), trace.WithAttributes(
            attribute.String(metrics.TxHash, log.TxHash.String()),
            attribute.Int(metrics.Origin, chainID),
            attribute.String(metrics.Contract, log.Address.String()),
            attribute.String("block_hash", log.BlockHash.String()),
          Severity: Major
          Found in services/rfq/guard/service/guard.go and 1 other location - About 1 hr to fix
          services/rfq/relayer/service/chainindexer.go on lines 64..70

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 142.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              group.Go(func() error {
        if !g.txSubmitter.Started() {
            err = g.txSubmitter.Start(ctx)
            // defensive coding against potential race.
            if err != nil && !errors.Is(err, submitter.ErrSubmitterAlreadyStarted) {
          Severity: Minor
          Found in services/rfq/guard/service/guard.go and 1 other location - About 35 mins to fix
          services/cctp-relayer/relayer/relayer.go on lines 307..315

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 103.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status