Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/rfq/relayer/service/chainindexer.go

Summary

Maintainability
C
1 day
Test Coverage

Method Relayer.runChainIndexer has a Cognitive Complexity of 30 (exceeds 20 allowed). Consider refactoring.
Open

func (r *Relayer) runChainIndexer(ctx context.Context, chainID int) (err error) {
    chainListener := r.chainListeners[chainID]

    parser, err := fastbridge.NewParser(chainListener.Address())
    if err != nil {
Severity: Minor
Found in services/rfq/relayer/service/chainindexer.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Relayer.runChainIndexer has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (r *Relayer) runChainIndexer(ctx context.Context, chainID int) (err error) {
    chainListener := r.chainListeners[chainID]

    parser, err := fastbridge.NewParser(chainListener.Address())
    if err != nil {
Severity: Minor
Found in services/rfq/relayer/service/chainindexer.go - About 1 hr to fix

    Method Relayer.runChainIndexer has 12 return statements (exceeds 4 allowed).
    Open

    func (r *Relayer) runChainIndexer(ctx context.Context, chainID int) (err error) {
    chainListener := r.chainListeners[chainID]

    parser, err := fastbridge.NewParser(chainListener.Address())
    if err != nil {
    Severity: Major
    Found in services/rfq/relayer/service/chainindexer.go - About 1 hr to fix

      Method Relayer.getDecimalsFromBridgeTx has 6 return statements (exceeds 4 allowed).
      Open

      func (r *Relayer) getDecimalsFromBridgeTx(parentCtx context.Context, bridgeTx fastbridge.IFastBridgeBridgeTransaction) (originDecimals *uint8, destDecimals *uint8, err error) {
    ctx, span := r.metrics.Tracer().Start(parentCtx, "getDecimals", trace.WithAttributes(
        attribute.String("sender", bridgeTx.OriginSender.String()),
    ))
      Severity: Major
      Found in services/rfq/relayer/service/chainindexer.go - About 40 mins to fix

        Method Relayer.getDecimals has 6 return statements (exceeds 4 allowed).
        Open

        func (r *Relayer) getDecimals(ctx context.Context, addr common.Address, chainID uint32) (decimals *uint8, err error) {
    // attempt to load decimal from cache
    key := getDecimalsKey(addr, chainID)
    decimals, ok := r.decimalsCache.Load(key)
    if ok {
        Severity: Major
        Found in services/rfq/relayer/service/chainindexer.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  ctx, span := r.metrics.Tracer().Start(parentCtx, fmt.Sprintf("handleLog-%s", et), trace.WithAttributes(
            attribute.String(metrics.TxHash, log.TxHash.String()),
            attribute.Int(metrics.Origin, chainID),
            attribute.String(metrics.Contract, log.Address.String()),
            attribute.String("block_hash", log.BlockHash.String()),
          Severity: Major
          Found in services/rfq/relayer/service/chainindexer.go and 1 other location - About 1 hr to fix
          services/rfq/guard/service/guard.go on lines 212..218

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 142.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  case *fastbridge.FastBridgeBridgeDepositClaimed:
            unlocker := r.handlerMtx.Lock(hexutil.Encode(event.TransactionId[:]))
            defer unlocker.Unlock()

            // it wasn't me
          Severity: Major
          Found in services/rfq/relayer/service/chainindexer.go and 2 other locations - About 55 mins to fix
          services/rfq/relayer/service/chainindexer.go on lines 82..96
          services/rfq/relayer/service/chainindexer.go on lines 97..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  case *fastbridge.FastBridgeBridgeRelayed:
            // blocking lock on the txid mutex to ensure state transitions are not overrwitten
            unlocker := r.handlerMtx.Lock(hexutil.Encode(event.TransactionId[:]))
            defer unlocker.Unlock()
          Severity: Major
          Found in services/rfq/relayer/service/chainindexer.go and 2 other locations - About 55 mins to fix
          services/rfq/relayer/service/chainindexer.go on lines 97..110
          services/rfq/relayer/service/chainindexer.go on lines 111..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  case *fastbridge.FastBridgeBridgeProofProvided:
            unlocker := r.handlerMtx.Lock(hexutil.Encode(event.TransactionId[:]))
            defer unlocker.Unlock()

            // it wasn't me
          Severity: Major
          Found in services/rfq/relayer/service/chainindexer.go and 2 other locations - About 55 mins to fix
          services/rfq/relayer/service/chainindexer.go on lines 82..96
          services/rfq/relayer/service/chainindexer.go on lines 111..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status