Sign upLogin

synapsecns/sanguine

View on GitHub
Star
services/scribe/service/indexer/indexer_test.go

Summary

Maintainability
D
2 days
Test Coverage

Method IndexerSuite.TestGetLogsSimulated has 86 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (x *IndexerSuite) TestGetLogsSimulated() {
    // Get simulated blockchain, deploy the test contract, and set up test variables.
    simulatedChain := geth.NewEmbeddedBackendForChainID(x.GetSuiteContext(), x.T(), big.NewInt(3))
    simulatedClient, err := backend.DialBackend(x.GetTestContext(), simulatedChain.RPCAddress(), x.metrics)
    Nil(x.T(), err)
Severity: Major
Found in services/scribe/service/indexer/indexer_test.go - About 2 hrs to fix

    Method IndexerSuite.TestContractBackfillFromPreIndexed has 64 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (x *IndexerSuite) TestContractBackfillFromPreIndexed() {
    // Get simulated blockchain, deploy the test contract, and set up test variables.
    simulatedChain := geth.NewEmbeddedBackendForChainID(x.GetSuiteContext(), x.T(), big.NewInt(142))
    simulatedClient, err := backend.DialBackend(x.GetTestContext(), simulatedChain.RPCAddress(), x.metrics)
    Nil(x.T(), err)
    Severity: Minor
    Found in services/scribe/service/indexer/indexer_test.go - About 1 hr to fix

      Method IndexerSuite.TestContractBackfill has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (x *IndexerSuite) TestContractBackfill() {
    // Get simulated blockchain, deploy the test contract, and set up test variables.
    simulatedChain := geth.NewEmbeddedBackendForChainID(x.GetSuiteContext(), x.T(), big.NewInt(142))
    simulatedClient, err := backend.DialBackend(x.GetTestContext(), simulatedChain.RPCAddress(), x.metrics)
    Nil(x.T(), err)
      Severity: Minor
      Found in services/scribe/service/indexer/indexer_test.go - About 1 hr to fix

        Method IndexerSuite.TestGetLogs has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (x *IndexerSuite) TestGetLogs() {
    const desiredBlockHeight = 10

    var testChainHandler *testutil.TestChainHandler
    var err error
        Severity: Minor
        Found in services/scribe/service/indexer/indexer_test.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (x *IndexerSuite) TestTxTypeNotSupported() {
    if os.Getenv("CI") != "" {
        x.T().Skip("Network test flake")
    }
          Severity: Major
          Found in services/scribe/service/indexer/indexer_test.go and 1 other location - About 6 hrs to fix
          services/scribe/service/indexer/indexer_test.go on lines 512..555

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 481.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func (x IndexerSuite) TestInvalidTxVRS() {
    if os.Getenv("CI") != "" {
        x.T().Skip("Network test flake")
    }
          Severity: Major
          Found in services/scribe/service/indexer/indexer_test.go and 1 other location - About 6 hrs to fix
          services/scribe/service/indexer/indexer_test.go on lines 464..507

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 481.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status