Sign upLogin

systori/bericht

View on GitHub
Star

Showing 55 of 55 total issues

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, document, page_number, css, size='letter', layout='portrait'):
Severity: Minor
Found in bericht/pdf/page.py - About 35 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if 'page_break_after' in kwargs:
            kwargs['page_break_after'] = kwargs['page_break_after'] == 'always'
    Severity: Minor
    Found in bericht/html/style.py and 1 other location - About 35 mins to fix
    bericht/html/style.py on lines 88..89

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if 'page_break_before' in kwargs:
            kwargs['page_break_before'] = kwargs['page_break_before'] == 'always'
    Severity: Minor
    Found in bericht/html/style.py and 1 other location - About 35 mins to fix
    bericht/html/style.py on lines 90..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

                    return TableColumn(node)
    Severity: Major
    Found in bericht/html/parser.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return (
      Severity: Major
      Found in bericht/html/box.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return TableColumnGroup(node)
        Severity: Major
        Found in bericht/html/parser.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return TableRow(node)
          Severity: Major
          Found in bericht/html/parser.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return ListItem(node)
            Severity: Major
            Found in bericht/html/parser.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return Block(node)
              Severity: Major
              Found in bericht/html/parser.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return TableCell(node)
                Severity: Major
                Found in bericht/html/parser.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return TableRowGroup(node)
                  Severity: Major
                  Found in bericht/html/parser.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return [] if not top_rows else [
                    Severity: Major
                    Found in bericht/html/table.py - About 30 mins to fix

                      Function calculate_widths has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def calculate_widths(self, available_width):

        widths = self.measurements.copy()

        fixed = sum(widths)
                      Severity: Minor
                      Found in bericht/html/table.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function apply has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def apply(self, node):
        for selectors, declarations in self.rules:
            for selector in selectors:
                if selector.matches(node):
                    declarations.apply(node)
                      Severity: Minor
                      Found in bericht/html/css.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function clone has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def clone(self, parent, lines, css):
        box = Box(parent or self.box.parent, self.box.tag, self.box.attrs)
        box.behavior = copy(self)
        box.behavior.box = box
        box.position = self.box.position
                      Severity: Minor
                      Found in bericht/html/box.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language