t1gor/Robots.txt-Parser-Class

Method process has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function process(string $line, array &$root, string &$currentUserAgent = '*', string $prevLine = '') {
        $parts     = explode(':', $line);
        $entry     = trim($parts[1]);
        $directive = $this->getDirectiveName();
 
 

The method process uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $this->log(strtr('{directive} with value {faulty} skipped as already exists for {useragent}', [
                '{directive}' => $directive,
                '{faulty}'    => $entry,
                '{useragent}' => $currentUserAgent,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Define a constant instead of duplicating this literal "{directive}" 3 times.

Open

                '{directive}' => $directive,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Define a constant instead of duplicating this literal "{useragent}" 3 times.

Open

                '{useragent}' => $currentUserAgent,

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid unused parameters such as '$prevLine'.

Open

    public function process(string $line, array &$root, string &$currentUserAgent = '*', string $prevLine = '') {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Opening brace of a class must be on the line after the definition

Open

abstract class AbstractAllowanceProcessor extends AbstractDirectiveProcessor implements DirectiveProcessorInterface {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{directive}' => $directive,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->log(strtr('{directive} with value {faulty} skipped as already exists for {useragent}', [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!preg_match("/^\//", $entry)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $root[$currentUserAgent][$directive] = [];

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{useragent}' => $currentUserAgent,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->log(strtr('{directive} with invalid value "{faulty}" found for {useragent}, skipping', [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!in_array($entry, $root[$currentUserAgent][$directive])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $root[$currentUserAgent][$directive][] = $entry;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ]));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ]));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    public function process(string $line, array &$root, string &$currentUserAgent = '*', string $prevLine = '') {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $entry     = trim($parts[1]);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{faulty}'    => $entry,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (!isset($root[$currentUserAgent][$directive])) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        if (empty($entry)) {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        } else {

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            $this->log(strtr('{directive} with empty value found for {useragent}, skipping', [

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{useragent}' => $currentUserAgent,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        }

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{useragent}' => $currentUserAgent,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{directive}' => $directive,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{faulty}'    => $entry,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $parts     = explode(':', $line);

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

                '{directive}' => $directive,

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

        $directive = $this->getDirectiveName();

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

            ]));

• Exclude checks
  • Disable engine
  • Disable check

Spaces must be used to indent lines; tabs are not allowed

Open

    }

• Exclude checks
  • Disable engine
  • Disable check

Opening brace should be on a new line

Open

    public function process(string $line, array &$root, string &$currentUserAgent = '*', string $prevLine = '') {

• Exclude checks
  • Disable engine
  • Disable check