Sign upLogin

t1gor/Robots.txt-Parser-Class

View on GitHub
Star
source/Parser/DirectiveProcessors/CrawlDelayProcessor.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$prevLine'.
Open

    public function process(string $line, array & $root, string & $currentUserAgent = '*', string $prevLine = '') {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Opening brace of a class must be on the line after the definition
Open

class CrawlDelayProcessor extends AbstractDirectiveProcessor implements DirectiveProcessorInterface {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $entry              = trim($parts[1]);
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        if (false === $filteredCrawlDelay) {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            $this->log(strtr('{directive} with value {faulty} dropped as invalid for {useragent}', [
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $parts              = explode(':', $line);
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                '{faulty}'    => $entry,
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function process(string $line, array & $root, string & $currentUserAgent = '*', string $prevLine = '') {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                '{useragent}' => $currentUserAgent
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            return;
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    }
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        }
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

    public function getDirectiveName(): string {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        return Directive::CRAWL_DELAY;
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

                '{directive}' => Directive::CRAWL_DELAY,
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

            ]));
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $filteredCrawlDelay = filter_var($entry, FILTER_VALIDATE_FLOAT, FILTER_FLAG_ALLOW_FRACTION);
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Spaces must be used to indent lines; tabs are not allowed
Open

        $root[$currentUserAgent][Directive::CRAWL_DELAY] = $filteredCrawlDelay;
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Opening brace should be on a new line
Open

    public function getDirectiveName(): string {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

Opening brace should be on a new line
Open

    public function process(string $line, array & $root, string & $currentUserAgent = '*', string $prevLine = '') {
Severity: Minor
Found in source/Parser/DirectiveProcessors/CrawlDelayProcessor.php by phpcodesniffer

There are no issues that match your filters.

Category
Status