t1gor/Robots.txt-Parser-Class

View on GitHub
source/Stream/CustomFilterInterface.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid variables with short names like $in. Configured minimum length is 3.
Open

    public function filter($in, $out, &$consumed, $closing);

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Opening brace of a interface must be on the line after the definition
Open

interface CustomFilterInterface {

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return int

Spaces must be used to indent lines; tabs are not allowed
Open

     *                   return. More data is required from the stream or prior filter.

Spaces must be used to indent lines; tabs are not allowed
Open

     * Called when closing the filter.

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param int $consumed

Spaces must be used to indent lines; tabs are not allowed
Open

     *   this means you will increment consumed by $bucket->datalen for each $bucket.

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     * Called when applying the filter.

Spaces must be used to indent lines; tabs are not allowed
Open

     *   in is a resource pointing to a bucket brigade which contains one or more bucket

Spaces must be used to indent lines; tabs are not allowed
Open

     *                               cannot continue.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     *   objects containing data to be filtered.

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param resource $out

Spaces must be used to indent lines; tabs are not allowed
Open

    public function filter($in, $out, &$consumed, $closing);

Spaces must be used to indent lines; tabs are not allowed
Open

     *   through the filterchain), the closing parameter will be set to TRUE.

Spaces must be used to indent lines; tabs are not allowed
Open

     *   - PSFS_ERR_FATAL (default): The filter experienced an unrecoverable error and

Spaces must be used to indent lines; tabs are not allowed
Open

     *   Your implementation of this method should return FALSE on failure, or TRUE on success.

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     * Called when creating the filter.

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param resource $in

Spaces must be used to indent lines; tabs are not allowed
Open

     *   out is a resource pointing to a second bucket brigade into which your modified

Spaces must be used to indent lines; tabs are not allowed
Open

     *   buckets should be placed.

Spaces must be used to indent lines; tabs are not allowed
Open

     * @param bool $closing

Spaces must be used to indent lines; tabs are not allowed
Open

     *

Spaces must be used to indent lines; tabs are not allowed
Open

     *   consumed, which must always be declared by reference, should be incremented by

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     *   the length of the data which your filter reads in and alters. In most cases

Spaces must be used to indent lines; tabs are not allowed
Open

     *   If the stream is in the process of closing (and therefore this is the last pass

Spaces must be used to indent lines; tabs are not allowed
Open

     *   The filter() method must return one of three values upon completion.

Spaces must be used to indent lines; tabs are not allowed
Open

     *   - PSFS_FEED_ME: Filter processed successfully, however no data was available to

Spaces must be used to indent lines; tabs are not allowed
Open

     *   - PSFS_PASS_ON: Filter processed successfully with data available in the out

Spaces must be used to indent lines; tabs are not allowed
Open

    public function onClose();

Spaces must be used to indent lines; tabs are not allowed
Open

    /**

Spaces must be used to indent lines; tabs are not allowed
Open

     * @return bool

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

     *                   bucket brigade.

Spaces must be used to indent lines; tabs are not allowed
Open

     */

Spaces must be used to indent lines; tabs are not allowed
Open

    public function onCreate();

There are no issues that match your filters.

Category
Status