source/Stream/Filters/TrimSpacesLeftFilter.php
Avoid unused parameters such as '$closing'. Open
Open
public function filter($in, $out, &$consumed, $closing) {- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid variables with short names like $in. Configured minimum length is 3. Open
Open
public function filter($in, $out, &$consumed, $closing) {- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}Source https://phpmd.org/rules/naming.html#shortvariable
Opening brace of a class must be on the line after the definition Open
Open
class TrimSpacesLeftFilter extends \php_user_filter implements CustomFilterInterface {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public const NAME = 'RTP_trim_spaces_both';- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public $filtername = self::NAME;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
stream_bucket_append($out, $bucket);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
}- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
public function filter($in, $out, &$consumed, $closing) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$bucket->data = preg_replace('/(^\s+)(?!\n$)/mui', '', $bucket->data);- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
return PSFS_PASS_ON;- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
while ($bucket = stream_bucket_make_writeable($in)) {- Exclude checks
Spaces must be used to indent lines; tabs are not allowed Open
Open
$consumed += $bucket->datalen;- Exclude checks
Opening brace should be on a new line Open
Open
public function filter($in, $out, &$consumed, $closing) {- Exclude checks