Sign upLogin

tableau-mkt/jquery.addressfield

View on GitHub
Star

Showing 10 of 10 total issues

Function factory has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
Open

}(function factory($) {
  /**
   * Modifies an address field for this wrapped set of fields, given a config
   * representing how the country writes its addresses (conforming roughly to
   * xNAL standards), and an array of fields you desire to show (again, roughly
Severity: Minor
Found in src/jquery.addressfield.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 250 lines of code (exceeds 25 allowed). Consider refactoring.
Open

}(function factory($) {
  /**
   * Modifies an address field for this wrapped set of fields, given a config
   * representing how the country writes its addresses (conforming roughly to
   * xNAL standards), and an array of fields you desire to show (again, roughly
Severity: Major
Found in src/jquery.addressfield.js - About 1 day to fix

    Function exports has 104 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    // Metadata.
    Severity: Major
    Found in Gruntfile.js - About 4 hrs to fix

      File jquery.addressfield.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * Address field
 * https://github.com/tableau-mkt/jquery.addressfield
 *
 * Licensed under the MIT license.
      Severity: Minor
      Found in src/jquery.addressfield.js - About 2 hrs to fix

        Function apply has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          $.fn.addressfield.apply = function (config, fieldMap) {
    var $container = $(this),
        fieldOrder = [],
        $element,
        selector,
        Severity: Minor
        Found in src/jquery.addressfield.js - About 2 hrs to fix

          Function addressfield has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            $.fn.addressfield = function(options) {
    var $container = this,
        configs = $.extend({
          fields: {},
          json: null,
          Severity: Minor
          Found in src/jquery.addressfield.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                var $this = $(this),
        elementName = $this.attr('id'),
        $label = $('label[for="' + elementName + '"]') || $this.prev('label');
            Severity: Minor
            Found in src/jquery.addressfield.js and 1 other location - About 50 mins to fix
            src/jquery.addressfield.js on lines 311..313

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                var $this = $(this),
        elementName = $this.attr('id'),
        $label = $('label[for="' + elementName + '"]') || $this.prev('label');
            Severity: Minor
            Found in src/jquery.addressfield.js and 1 other location - About 50 mins to fix
            src/jquery.addressfield.js on lines 444..446

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 52.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid deeply nested control flow statements.
            Open

                        if (!$element.is('select')) {
              $element = $.fn.addressfield.convertToSelect.call($element);
            }
            Severity: Major
            Found in src/jquery.addressfield.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if ($element.is('select')) {
              $element = $.fn.addressfield.convertToText.call($element);
            }
              Severity: Major
              Found in src/jquery.addressfield.js - About 45 mins to fix
                Severity
                Category
                Status
                Source
                Language