Sign upLogin

takeawaytown/laravel-uuid

View on GitHub
Star

Showing 109 of 109 total issues

Method __get has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Confirmed

    public function __get($var)
    {
        switch ($var) {
            case "bytes":
                return $this->bytes;
Severity: Minor
Found in src/Classes/Uuid.php - About 1 hr to fix

Function __get has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Confirmed

    public function __get($var)
    {
        switch ($var) {
            case "bytes":
                return $this->bytes;
Severity: Minor
Found in src/Classes/Uuid.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function nameGenerator has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function nameGenerator($ver, $node, $namespace)
    {
        // if the namespace UUID isn't binary, make it so
        $namespace = static::makeBinary($namespace, 16);
        $version = null;
Severity: Minor
Found in src/Classes/Uuid.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return (string) $this->__toString();
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

The method scopeUuid has a boolean flag argument $first, which is a certain sign of a Single Responsibility Principle violation.
Open

  public function scopeUuid($query, $uuid, $first = true)
Severity: Minor
Found in src/Traits/Uuid.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid too many return statements within this method.
Open

                    return (int) 1;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return (int) ord($this->bytes[6]) >> 4;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return (int) (hexdec($time) - static::INTERVAL) / 10000000;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return (int) 0;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return null;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return null;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                return "urn:uuid:" . $this->__toString();
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return (int) 2;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

Avoid too many return statements within this method.
Open

                    return (int) 3;
Severity: Major
Found in src/Classes/Uuid.php - About 30 mins to fix

The method makeBinary uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return pack("H*", $str);
        }
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __get uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    return (int) 0;
                }
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __get uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    return null;
                }
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __get uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

                } else {
                    return null;
                }
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method makeBinary uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            // strip URN scheme and namespace
            $str = preg_replace('/^urn:uuid:/is', '', $str);
        }
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method __get() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
Open

    public function __get($var)
    {
        switch ($var) {
            case "bytes":
                return $this->bytes;
Severity: Minor
Found in src/Classes/Uuid.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Severity
Category
Status
Source
Language