Sign upLogin

talho/openphin

View on GitHub
Star
app/controllers/admin/invitations_controller.rb

Summary

Maintainability
D
1 day
Test Coverage

Method show has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    @invitation = Invitation.find(params[:id])
    respond_to do |format|
      format.html
      format.json do
Severity: Minor
Found in app/controllers/admin/invitations_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def show
    @invitation = Invitation.find(params[:id])
    respond_to do |format|
      format.html
      format.json do
Severity: Minor
Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

    Method create has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def create
    paramsWithCSVInvitees unless params[:invitation][:csvfile].blank?
    params[:invitation].delete("csvfile")
    params[:invitation][:author_id] = current_user.id
    Severity: Minor
    Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method import has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def import
    invitees = []
    csvfile = params[:invitation][:csvfile]
    newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
    File.open(newfile,'wb') do |file|
    Severity: Minor
    Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

      Method paramsWithCSVInvitees has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def paramsWithCSVInvitees
    csvfile = params[:invitation][:csvfile]
    newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
    File.open(newfile,'wb') do |file|
      file.puts csvfile.read
      Severity: Minor
      Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

        Method paramsWithCSVInvitees has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def paramsWithCSVInvitees
    csvfile = params[:invitation][:csvfile]
    newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
    File.open(newfile,'wb') do |file|
      file.puts csvfile.read
        Severity: Minor
        Found in app/controllers/admin/invitations_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method import has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def import
    invitees = []
    csvfile = params[:invitation][:csvfile]
    newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
    File.open(newfile,'wb') do |file|
        Severity: Minor
        Found in app/controllers/admin/invitations_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method find_invitees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def find_invitees
    params[:dir] ||= 'DESC'
    params[:sort] = params[:sort] ? params[:sort].underscore : 'name'
    
    params[:per_page] = params[:limit].to_i || 20
        Severity: Minor
        Found in app/controllers/admin/invitations_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            respond_to do |format|
      format.html do
        if error.nil?
          render :json => {:success => true, :invitees_attributes => invitees}.as_json, :content_type => 'text/html'
        else
        Severity: Major
        Found in app/controllers/admin/invitations_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/admin/user_batch_controller.rb on lines 115..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status