Sign upLogin

talho/openphin

View on GitHub
Star
app/controllers/admin/role_requests_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method approve has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def approve
    role_req=RoleRequest.find(params[:id])
    if role_req
      if current_user.is_admin_for?(role_req.jurisdiction)
        role_req.approve!(current_user)
Severity: Minor
Found in app/controllers/admin/role_requests_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deny has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def deny
    role_req=RoleRequest.find(params[:id])
    if role_req
      if current_user.is_admin_for?(role_req.jurisdiction)
        role_req.deny!
Severity: Minor
Found in app/controllers/admin/role_requests_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deny has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def deny
    role_req=RoleRequest.find(params[:id])
    if role_req
      if current_user.is_admin_for?(role_req.jurisdiction)
        role_req.deny!
Severity: Minor
Found in app/controllers/admin/role_requests_controller.rb - About 1 hr to fix

    Method approve has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def approve
    role_req=RoleRequest.find(params[:id])
    if role_req
      if current_user.is_admin_for?(role_req.jurisdiction)
        role_req.approve!(current_user)
    Severity: Minor
    Found in app/controllers/admin/role_requests_controller.rb - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              respond_to do |format|
          format.html do
            link = "<a href=\"#{user_profile_path(role_req.user)}\">#{role_req.user.display_name}</a>"
            flash[:notice]="#{link} has been denied for the role #{role_req.role.name} in #{role_req.jurisdiction.name}"
      Severity: Major
      Found in app/controllers/admin/role_requests_controller.rb and 1 other location - About 2 hrs to fix
      app/controllers/admin/role_requests_controller.rb on lines 78..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              respond_to do |format|
          format.html do
            link = "<a href=\"#{user_profile_path(role_req.user)}\">#{role_req.user.display_name}</a>"
            flash[:notice]="#{link} has been approved for the role #{role_req.role.name} in #{role_req.jurisdiction.name}"
      Severity: Major
      Found in app/controllers/admin/role_requests_controller.rb and 1 other location - About 2 hrs to fix
      app/controllers/admin/role_requests_controller.rb on lines 125..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 90.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              respond_to do |format|
          format.html do
            flash[:error]="This resource does not exist or is not available."
            if request.xhr?
              redirect_to :action => "index", :controller => "admin/role_requests", :format => "ext"
      Severity: Minor
      Found in app/controllers/admin/role_requests_controller.rb and 1 other location - About 1 hr to fix
      app/controllers/admin/role_requests_controller.rb on lines 101..113

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              respond_to do |format|
          format.html do
            flash[:error]="This resource does not exist or is not available."
            if request.xhr?
              redirect_to :action => "index", :controller => "admin/role_requests", :format => "ext"
      Severity: Minor
      Found in app/controllers/admin/role_requests_controller.rb and 1 other location - About 1 hr to fix
      app/controllers/admin/role_requests_controller.rb on lines 149..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status