Sign upLogin

talho/openphin

View on GitHub
Star
app/controllers/search_modules/search.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method sanitize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def sanitize(conditions,exclude=[:phone])
      return unless conditions
      email = /[:"\*\!&]/
      other = /[:"@\-\*\!\~\&]/
      conditions.reject{ |k,v| exclude.include? k }.each do |k,v|
Severity: Minor
Found in app/controllers/search_modules/search.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_options has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def build_options(params)
      #  map EXT params to Sphinx params
      if params[:limit].present?
          params[:per_page] =  params.delete(:limit)
      end
Severity: Minor
Found in app/controllers/search_modules/search.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status