Method update
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def update
if (params[:topic] && params[:topic][:comment_attributes] && params[:topic][:comment_attributes][:comment_id])
parent_topic = Topic.find(params[:topic][:comment_attributes][:comment_id])
while not parent_topic.comment_id.nil?
parent_topic = Topic.find(parent_topic.comment_id)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method active_topics
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def active_topics
params[:forums].delete('')
forums = if params[:forums].blank?
Forum.for_user(current_user)
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method recent_posts
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def recent_posts
params[:forums].delete('')
forums = if params[:forums].blank?
Forum.for_user(current_user)
else
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update
if (params[:topic] && params[:topic][:comment_attributes] && params[:topic][:comment_attributes][:comment_id])
parent_topic = Topic.find(params[:topic][:comment_attributes][:comment_id])
while not parent_topic.comment_id.nil?
parent_topic = Topic.find(parent_topic.comment_id)