Showing 3,486 of 3,486 total issues
Function onResize
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onResize : function(w, h){
var body = this.innerBody.dom,
header = this.innerHd.dom,
scrollWidth = w - Ext.num(this.scrollOffset, Ext.getScrollBarWidth()) + 'px',
parentNode;
Function onTriggerClick
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onTriggerClick : function(){
if(this.disabled){
return;
}
if(this.menu == null){
Function restore
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
restore : function(){
if(this.maximized){
var t = this.tools;
this.el.removeClass('x-window-maximized');
if(t.restore){
Function onRemove
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onRemove : function(c){
var te = Ext.get(c.tabEl);
// check if the tabEl exists, it won't if the tab isn't rendered
if(te){
te.select('a').removeAllListeners();
Function onRender
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onRender : function(ct, position){
Ext.TabPanel.superclass.onRender.call(this, ct, position);
if(this.plain){
var pos = this.tabPosition == 'top' ? 'header' : 'footer';
Function onLayout
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onLayout: function(container, target) {
Ext.layout.BoxLayout.superclass.onLayout.call(this, container, target);
var tSize = this.getLayoutTargetSize(),
items = this.getVisibleItems(container),
Function onRender
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onRender : function(ct, position){
if(!this.template){
if(!Ext.Button.buttonTemplate){
// hideous table template
Ext.Button.buttonTemplate = new Ext.Template(
Function initComponent
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
initComponent : function(){
if(Ext.isArray(this.initialConfig)){
Ext.apply(this, {items:this.initialConfig});
}
this.addEvents(
Function resizeImage
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
resizeImage: function(w, h){
var wCur = els.outerImageContainer.getWidth();
var hCur = els.outerImageContainer.getHeight();
var wNew = (w + this.borderSize * 2);
Function getState
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
getState : function(){
var o = {columns: []},
store = this.store,
ss,
gs;
Function shift
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
shift : function(o){
o = getObject(o);
var dom = this.dom,
a = {};
Function onRemove
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onRemove : function(c){
var te = Ext.get(c.tabEl);
// check if the tabEl exists, it won't if the tab isn't rendered
if(te){
te.select('a').removeAllListeners();
Function addTopicsView
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
addTopicsView: function(){
this.store = new Ext.data.JsonStore({
fields: ['name', 'id', {name:'last_comment_time', type:'date'}, 'last_comment_poster_name', 'last_comment_poster_id', 'forum_name', 'forum_id'],
restful: true,
url: '/forums/topics/active_topics.json',
Function onRender
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
onRender : function(ct, position){
Ext.ux.tot2ivn.VrTabPanel.superclass.onRender.call(this, ct, position);
if(this.plain){
var pos = this.tabPosition == 'top' ? 'header' : 'footer';
Method paramsWithCSVInvitees
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def paramsWithCSVInvitees
csvfile = params[:invitation][:csvfile]
newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
File.open(newfile,'wb') do |file|
file.puts csvfile.read
Consider simplifying this complex logical expression. Open
if(c){
w = me.getWidth();
h = me.getHeight();
r = el.getRegion();
//If we are at a viewport boundary and the aligned el is anchored on a target border that is
Consider simplifying this complex logical expression. Open
if(Ext.dd.DropZone){
Ext.tree.TreeDropZone = function(tree, config){
/**
* @cfg {Boolean} allowParentInsert
Function setBounds
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
setBounds : function(x, y, w, h, a, d, c, e){
Consider simplifying this complex logical expression. Open
if(this.showToday){
var td = new Date().clearTime(),
disable = (td < min || td > max ||
(ddMatch && format && ddMatch.test(td.dateFormat(format))) ||
(ddays && ddays.indexOf(td.getDay()) != -1));
Similar blocks of code found in 113 locations. Consider refactoring. Open
if(Ext.grid.PropertyColumnModel){
Ext.apply(Ext.grid.PropertyColumnModel.prototype, {
nameText : "Nome",
valueText : "Valor",
dateFormat : "d/m/Y"
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 55.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76