talho/openphin

View on GitHub

Showing 3,486 of 3,486 total issues

Function onResize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onResize : function(w, h){
        var body = this.innerBody.dom,
            header = this.innerHd.dom,
            scrollWidth = w - Ext.num(this.scrollOffset, Ext.getScrollBarWidth()) + 'px',
            parentNode;
Severity: Minor
Found in app/assets/javascripts/ext/src/widgets/list/ListView.js - About 1 hr to fix

    Function onTriggerClick has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        onTriggerClick : function(){
            if(this.disabled){
                return;
            }
            if(this.menu == null){
    Severity: Minor
    Found in app/assets/javascripts/ext/src/widgets/form/DateField.js - About 1 hr to fix

      Function restore has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          restore : function(){
              if(this.maximized){
                  var t = this.tools;
                  this.el.removeClass('x-window-maximized');
                  if(t.restore){
      Severity: Minor
      Found in app/assets/javascripts/ext/src/widgets/Window.js - About 1 hr to fix

        Function onRemove has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            onRemove : function(c){
                var te = Ext.get(c.tabEl);
                // check if the tabEl exists, it won't if the tab isn't rendered
                if(te){
                    te.select('a').removeAllListeners();
        Severity: Minor
        Found in app/assets/javascripts/ext/src/widgets/TabPanel.js - About 1 hr to fix

          Function onRender has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              onRender : function(ct, position){
                  Ext.TabPanel.superclass.onRender.call(this, ct, position);
          
                  if(this.plain){
                      var pos = this.tabPosition == 'top' ? 'header' : 'footer';
          Severity: Minor
          Found in app/assets/javascripts/ext/src/widgets/TabPanel.js - About 1 hr to fix

            Function onLayout has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                onLayout: function(container, target) {
                    Ext.layout.BoxLayout.superclass.onLayout.call(this, container, target);
            
                    var tSize = this.getLayoutTargetSize(),
                        items = this.getVisibleItems(container),
            Severity: Minor
            Found in app/assets/javascripts/ext/src/widgets/layout/BoxLayout.js - About 1 hr to fix

              Function onRender has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  onRender : function(ct, position){
                      if(!this.template){
                          if(!Ext.Button.buttonTemplate){
                              // hideous table template
                              Ext.Button.buttonTemplate = new Ext.Template(
              Severity: Minor
              Found in app/assets/javascripts/ext/src/widgets/Button.js - About 1 hr to fix

                Function initComponent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    initComponent : function(){
                        if(Ext.isArray(this.initialConfig)){
                            Ext.apply(this, {items:this.initialConfig});
                        }
                        this.addEvents(
                Severity: Minor
                Found in app/assets/javascripts/ext/src/widgets/menu/Menu.js - About 1 hr to fix

                  Function resizeImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          resizeImage: function(w, h){
                              var wCur = els.outerImageContainer.getWidth();
                              var hCur = els.outerImageContainer.getHeight();
                  
                              var wNew = (w + this.borderSize * 2);

                    Function getState has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getState : function(){
                            var o = {columns: []},
                                store = this.store,
                                ss,
                                gs;
                    Severity: Minor
                    Found in app/assets/javascripts/ext/src/widgets/grid/GridPanel.js - About 1 hr to fix

                      Function shift has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          shift : function(o){
                              o = getObject(o);
                              var dom = this.dom,
                                  a = {};
                                      
                      Severity: Minor
                      Found in app/assets/javascripts/ext/src/ext-core/src/core/Fx.js - About 1 hr to fix

                        Function onRemove has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            onRemove : function(c){
                                var te = Ext.get(c.tabEl);
                                // check if the tabEl exists, it won't if the tab isn't rendered
                                if(te){
                                    te.select('a').removeAllListeners();

                          Function addTopicsView has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            addTopicsView: function(){
                              this.store = new Ext.data.JsonStore({
                                fields: ['name', 'id', {name:'last_comment_time', type:'date'}, 'last_comment_poster_name', 'last_comment_poster_id', 'forum_name', 'forum_id'],
                                restful: true,
                                url: '/forums/topics/active_topics.json',
                          Severity: Minor
                          Found in app/assets/javascripts/dashboard/cms/portlets/forum.js - About 1 hr to fix

                            Function onRender has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                onRender : function(ct, position){
                                    Ext.ux.tot2ivn.VrTabPanel.superclass.onRender.call(this, ct, position);
                            
                                    if(this.plain){
                                        var pos = this.tabPosition == 'top' ? 'header' : 'footer';

                              Method paramsWithCSVInvitees has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                def paramsWithCSVInvitees
                                  csvfile = params[:invitation][:csvfile]
                                  newfile = File.join(Rails.root.to_s,'tmp',csvfile.original_filename)
                                  File.open(newfile,'wb') do |file|
                                    file.puts csvfile.read
                              Severity: Minor
                              Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

                                Consider simplifying this complex logical expression.
                                Open

                                        if(c){    
                                           w = me.getWidth();
                                           h = me.getHeight();
                                           r = el.getRegion();       
                                           //If we are at a viewport boundary and the aligned el is anchored on a target border that is
                                Severity: Major
                                Found in app/assets/javascripts/ext/src/core/Element.alignment.js - About 1 hr to fix

                                  Consider simplifying this complex logical expression.
                                  Open

                                  if(Ext.dd.DropZone){
                                      
                                  Ext.tree.TreeDropZone = function(tree, config){
                                      /**
                                       * @cfg {Boolean} allowParentInsert
                                  Severity: Major
                                  Found in app/assets/javascripts/ext/src/widgets/tree/TreeDropZone.js - About 1 hr to fix

                                    Function setBounds has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        setBounds : function(x, y, w, h, a, d, c, e){
                                    Severity: Major
                                    Found in app/assets/javascripts/ext/src/widgets/Layer.js - About 1 hr to fix

                                      Consider simplifying this complex logical expression.
                                      Open

                                                  if(this.showToday){
                                                      var td = new Date().clearTime(),
                                                          disable = (td < min || td > max ||
                                                          (ddMatch && format && ddMatch.test(td.dateFormat(format))) ||
                                                          (ddays && ddays.indexOf(td.getDay()) != -1));
                                      Severity: Major
                                      Found in app/assets/javascripts/ext/src/widgets/DatePicker.js - About 1 hr to fix

                                        Similar blocks of code found in 113 locations. Consider refactoring.
                                        Open

                                        if(Ext.grid.PropertyColumnModel){
                                           Ext.apply(Ext.grid.PropertyColumnModel.prototype, {
                                              nameText   : "Nome",
                                              valueText  : "Valor",
                                              dateFormat : "d/m/Y"
                                        Severity: Major
                                        Found in app/assets/javascripts/ext/src/locale/ext-lang-pt_BR.js and 112 other locations - About 1 hr to fix
                                        app/assets/javascripts/ext/src/locale/ext-lang-af.js on lines 125..131
                                        app/assets/javascripts/ext/src/locale/ext-lang-af.js on lines 171..177
                                        app/assets/javascripts/ext/src/locale/ext-lang-bg.js on lines 141..147
                                        app/assets/javascripts/ext/src/locale/ext-lang-bg.js on lines 265..271
                                        app/assets/javascripts/ext/src/locale/ext-lang-ca.js on lines 264..270
                                        app/assets/javascripts/ext/src/locale/ext-lang-ca.js on lines 272..278
                                        app/assets/javascripts/ext/src/locale/ext-lang-ca.js on lines 280..286
                                        app/assets/javascripts/ext/src/locale/ext-lang-cs.js on lines 165..171
                                        app/assets/javascripts/ext/src/locale/ext-lang-cs.js on lines 289..295
                                        app/assets/javascripts/ext/src/locale/ext-lang-cs.js on lines 297..303
                                        app/assets/javascripts/ext/src/locale/ext-lang-da.js on lines 151..157
                                        app/assets/javascripts/ext/src/locale/ext-lang-da.js on lines 283..289
                                        app/assets/javascripts/ext/src/locale/ext-lang-de.js on lines 285..291
                                        app/assets/javascripts/ext/src/locale/ext-lang-de.js on lines 293..299
                                        app/assets/javascripts/ext/src/locale/ext-lang-el_GR.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-el_GR.js on lines 287..293
                                        app/assets/javascripts/ext/src/locale/ext-lang-el_GR.js on lines 295..301
                                        app/assets/javascripts/ext/src/locale/ext-lang-en.js on lines 272..278
                                        app/assets/javascripts/ext/src/locale/ext-lang-en.js on lines 280..286
                                        app/assets/javascripts/ext/src/locale/ext-lang-en.js on lines 298..304
                                        app/assets/javascripts/ext/src/locale/ext-lang-en_GB.js on lines 268..274
                                        app/assets/javascripts/ext/src/locale/ext-lang-en_GB.js on lines 276..282
                                        app/assets/javascripts/ext/src/locale/ext-lang-es.js on lines 267..273
                                        app/assets/javascripts/ext/src/locale/ext-lang-es.js on lines 275..281
                                        app/assets/javascripts/ext/src/locale/ext-lang-es.js on lines 283..289
                                        app/assets/javascripts/ext/src/locale/ext-lang-fa.js on lines 136..142
                                        app/assets/javascripts/ext/src/locale/ext-lang-fa.js on lines 259..265
                                        app/assets/javascripts/ext/src/locale/ext-lang-fi.js on lines 153..159
                                        app/assets/javascripts/ext/src/locale/ext-lang-fi.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-fi.js on lines 289..295
                                        app/assets/javascripts/ext/src/locale/ext-lang-fr.js on lines 289..295
                                        app/assets/javascripts/ext/src/locale/ext-lang-fr.js on lines 297..303
                                        app/assets/javascripts/ext/src/locale/ext-lang-fr_CA.js on lines 160..166
                                        app/assets/javascripts/ext/src/locale/ext-lang-fr_CA.js on lines 205..211
                                        app/assets/javascripts/ext/src/locale/ext-lang-gr.js on lines 117..123
                                        app/assets/javascripts/ext/src/locale/ext-lang-gr.js on lines 162..168
                                        app/assets/javascripts/ext/src/locale/ext-lang-he.js on lines 147..153
                                        app/assets/javascripts/ext/src/locale/ext-lang-he.js on lines 271..277
                                        app/assets/javascripts/ext/src/locale/ext-lang-he.js on lines 279..285
                                        app/assets/javascripts/ext/src/locale/ext-lang-hr.js on lines 151..157
                                        app/assets/javascripts/ext/src/locale/ext-lang-hr.js on lines 274..280
                                        app/assets/javascripts/ext/src/locale/ext-lang-hr.js on lines 282..288
                                        app/assets/javascripts/ext/src/locale/ext-lang-hu.js on lines 151..157
                                        app/assets/javascripts/ext/src/locale/ext-lang-hu.js on lines 275..281
                                        app/assets/javascripts/ext/src/locale/ext-lang-hu.js on lines 283..289
                                        app/assets/javascripts/ext/src/locale/ext-lang-id.js on lines 156..162
                                        app/assets/javascripts/ext/src/locale/ext-lang-id.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-id.js on lines 289..295
                                        app/assets/javascripts/ext/src/locale/ext-lang-it.js on lines 149..155
                                        app/assets/javascripts/ext/src/locale/ext-lang-it.js on lines 273..279
                                        app/assets/javascripts/ext/src/locale/ext-lang-it.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-ja.js on lines 267..273
                                        app/assets/javascripts/ext/src/locale/ext-lang-ja.js on lines 275..281
                                        app/assets/javascripts/ext/src/locale/ext-lang-ja.js on lines 283..289
                                        app/assets/javascripts/ext/src/locale/ext-lang-ko.js on lines 121..127
                                        app/assets/javascripts/ext/src/locale/ext-lang-ko.js on lines 244..251
                                        app/assets/javascripts/ext/src/locale/ext-lang-ko.js on lines 253..259
                                        app/assets/javascripts/ext/src/locale/ext-lang-lt.js on lines 162..168
                                        app/assets/javascripts/ext/src/locale/ext-lang-lt.js on lines 290..296
                                        app/assets/javascripts/ext/src/locale/ext-lang-lt.js on lines 298..304
                                        app/assets/javascripts/ext/src/locale/ext-lang-lv.js on lines 118..124
                                        app/assets/javascripts/ext/src/locale/ext-lang-lv.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-mk.js on lines 118..124
                                        app/assets/javascripts/ext/src/locale/ext-lang-mk.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-nl.js on lines 272..278
                                        app/assets/javascripts/ext/src/locale/ext-lang-nl.js on lines 280..286
                                        app/assets/javascripts/ext/src/locale/ext-lang-nl.js on lines 288..294
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NB.js on lines 149..155
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NB.js on lines 273..279
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NB.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NN.js on lines 149..155
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NN.js on lines 273..279
                                        app/assets/javascripts/ext/src/locale/ext-lang-no_NN.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-pl.js on lines 159..165
                                        app/assets/javascripts/ext/src/locale/ext-lang-pl.js on lines 283..289
                                        app/assets/javascripts/ext/src/locale/ext-lang-pl.js on lines 291..297
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt.js on lines 124..130
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt.js on lines 247..253
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt_BR.js on lines 166..172
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt_PT.js on lines 148..154
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt_PT.js on lines 276..282
                                        app/assets/javascripts/ext/src/locale/ext-lang-pt_PT.js on lines 284..290
                                        app/assets/javascripts/ext/src/locale/ext-lang-ro.js on lines 149..155
                                        app/assets/javascripts/ext/src/locale/ext-lang-ro.js on lines 274..280
                                        app/assets/javascripts/ext/src/locale/ext-lang-ro.js on lines 282..288
                                        app/assets/javascripts/ext/src/locale/ext-lang-ru.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-ru.js on lines 291..297
                                        app/assets/javascripts/ext/src/locale/ext-lang-ru.js on lines 299..305
                                        app/assets/javascripts/ext/src/locale/ext-lang-sk.js on lines 124..130
                                        app/assets/javascripts/ext/src/locale/ext-lang-sk.js on lines 169..175
                                        app/assets/javascripts/ext/src/locale/ext-lang-sl.js on lines 118..124
                                        app/assets/javascripts/ext/src/locale/ext-lang-sl.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-sr.js on lines 120..126
                                        app/assets/javascripts/ext/src/locale/ext-lang-sr.js on lines 166..172
                                        app/assets/javascripts/ext/src/locale/ext-lang-sr_RS.js on lines 120..126
                                        app/assets/javascripts/ext/src/locale/ext-lang-sr_RS.js on lines 165..171
                                        app/assets/javascripts/ext/src/locale/ext-lang-sv_SE.js on lines 120..126
                                        app/assets/javascripts/ext/src/locale/ext-lang-sv_SE.js on lines 165..171
                                        app/assets/javascripts/ext/src/locale/ext-lang-th.js on lines 149..155
                                        app/assets/javascripts/ext/src/locale/ext-lang-th.js on lines 273..279
                                        app/assets/javascripts/ext/src/locale/ext-lang-th.js on lines 281..287
                                        app/assets/javascripts/ext/src/locale/ext-lang-tr.js on lines 163..169
                                        app/assets/javascripts/ext/src/locale/ext-lang-tr.js on lines 285..291
                                        app/assets/javascripts/ext/src/locale/ext-lang-tr.js on lines 293..299
                                        app/assets/javascripts/ext/src/locale/ext-lang-ukr.js on lines 125..131
                                        app/assets/javascripts/ext/src/locale/ext-lang-ukr.js on lines 248..254
                                        app/assets/javascripts/ext/src/locale/ext-lang-vn.js on lines 123..129
                                        app/assets/javascripts/ext/src/locale/ext-lang-vn.js on lines 168..174
                                        app/assets/javascripts/ext/src/locale/ext-lang-zh_CN.js on lines 126..132
                                        app/assets/javascripts/ext/src/locale/ext-lang-zh_CN.js on lines 250..256
                                        app/assets/javascripts/ext/src/locale/ext-lang-zh_TW.js on lines 120..126
                                        app/assets/javascripts/ext/src/locale/ext-lang-zh_TW.js on lines 165..171

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 55.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language