Sign upLogin

talho/openphin

View on GitHub
Star

Showing 3,486 of 3,486 total issues

Function ScrollManager has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Ext.dd.ScrollManager = function(){
    var ddm = Ext.dd.DragDropMgr;
    var els = {};
    var dragEl = null;
    var proc = {};
Severity: Major
Found in app/assets/javascripts/ext/src/dd/ScrollManager.js - About 4 hrs to fix

    Function History has 123 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Ext.History = (function () {
    var iframe, hiddenField;
    var ready = false;
    var currentToken;
    Severity: Major
    Found in app/assets/javascripts/ext/src/util/History.js - About 4 hrs to fix

      Function update has 123 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          update : function(date, forceRefresh){
        if(this.rendered){
            var vd = this.activeDate, vis = this.isVisible();
            this.activeDate = date;
            if(!forceRefresh && vd && this.el){
      Severity: Major
      Found in app/assets/javascripts/ext/src/widgets/DatePicker.js - About 4 hrs to fix

        Function constructor has 123 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            constructor: function(config)
    {
        Ext.apply(this, config);

        Talho.Article3Panel.superclass.constructor.call(this, config);
        Severity: Major
        Found in app/assets/javascripts/dashboard/article3panel.js - About 4 hrs to fix

          File Field.js has 371 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
          Severity: Minor
          Found in app/assets/javascripts/ext/src/widgets/form/Field.js - About 4 hrs to fix

            File Layer.js has 369 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
            Severity: Minor
            Found in app/assets/javascripts/ext/src/widgets/Layer.js - About 4 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                showReportSchedules: function(){
    var layout = this.getPanel();
    while(layout.items.itemAt(1)){
      layout.remove(layout.items.itemAt(1));
    }
              Severity: Major
              Found in app/assets/javascripts/reports/Controller.js and 1 other location - About 4 hrs to fix
              app/assets/javascripts/reports/Controller.js on lines 27..37

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (Ext.isArray(rs)) {
            for (var i = rs.length - 1; i >= 0; i--) {
                // recurse
                if (Ext.isArray(data)) {
                    this.realize(rs.splice(i,1).shift(), data.splice(i,1).shift());
              Severity: Major
              Found in app/assets/javascripts/ext/src/data/DataReader.js and 1 other location - About 4 hrs to fix
              app/assets/javascripts/ext_extensions/RailsJsonReader.js on lines 6..35

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                      if (Ext.isArray(rs)) {
            for (var i = rs.length - 1; i >= 0; i--) {
                // recurse
                if (Ext.isArray(data)) {
                    this.realize(rs.splice(i,1).shift(), data.splice(i,1).shift());
              Severity: Major
              Found in app/assets/javascripts/ext_extensions/RailsJsonReader.js and 1 other location - About 4 hrs to fix
              app/assets/javascripts/ext/src/data/DataReader.js on lines 86..115

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                showNewReport: function(){
    var layout = this.getPanel();
    while(layout.items.itemAt(1)){
      layout.remove(layout.items.itemAt(1));
    }
              Severity: Major
              Found in app/assets/javascripts/reports/Controller.js and 1 other location - About 4 hrs to fix
              app/assets/javascripts/reports/Controller.js on lines 39..49

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function initComponent has 119 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                initComponent : function() {
    this.setTitle('Topic: '+ this.topicName);
    
    if(!this.items) {
      this.items = [];
              Severity: Major
              Found in app/assets/javascripts/forums/view/topics/Show.js - About 4 hrs to fix

                Function Registry has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                Ext.dd.Registry = function(){
    var elements = {}; 
    var handles = {}; 
    var autoIdSeed = 0;
                Severity: Minor
                Found in app/assets/javascripts/ext/src/dd/Registry.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function History has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                Ext.History = (function () {
    var iframe, hiddenField;
    var ready = false;
    var currentToken;
                Severity: Minor
                Found in app/assets/javascripts/ext/src/util/History.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function onLayout has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                    onLayout : function(container, target) {
        Ext.layout.AnchorLayout.superclass.onLayout.call(this, container, target);

        var size = this.getLayoutTargetSize(),
            containerWidth = size.width,
                Severity: Minor
                Found in app/assets/javascripts/ext/src/widgets/layout/AnchorLayout.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function TaskRunner has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                Ext.util.TaskRunner = function(interval){
    interval = interval || 10;
    var tasks = [], 
        removeQueue = [],
        id = 0,
                Severity: Minor
                Found in app/assets/javascripts/ext/src/ext-core/src/util/TaskMgr.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function loadRecords has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                Open

                    loadRecords : function(o, options, success)
    {
        if (!o || success === false) {
            if (success !== false) {
                this.fireEvent("load", this, [], options);
                Severity: Minor
                Found in app/assets/javascripts/ext_extensions/TreeGrid/src/AbstractTreeStore.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function click has 117 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            click: function(column, grid, rowIndex, e){
              if(grid.store.getAt(rowIndex).data['pending_requests'].length == 0) return;
              var i = [{
                html: 'Role'
              },{
                Severity: Major
                Found in app/assets/javascripts/invitations/Invitations.js - About 4 hrs to fix

                  Method update has 117 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def update
    set_toolbar
    find_user_and_profile
    success = true
    errors = Array.new
                  Severity: Major
                  Found in app/controllers/user_profiles_controller.rb - About 4 hrs to fix

                    File ToolTip.js has 361 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    /*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
                    Severity: Minor
                    Found in app/assets/javascripts/ext/src/widgets/tips/ToolTip.js - About 4 hrs to fix

                      Function EventObject has 116 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      Ext.EventObject = function(){
    var E = Ext.lib.Event,
        clickRe = /(dbl)?click/,
        // safari keypress events for special keys return bad keycodes
        safariKeys = {
                      Severity: Major
                      Found in app/assets/javascripts/ext/src/ext-core/src/core/EventManager.js - About 4 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language