talho/openphin

View on GitHub

Showing 3,486 of 3,486 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Ext.ux.maximgb.tg.NestedSetStore = Ext.extend(Ext.ux.maximgb.tg.AbstractTreeStore,
{
    /**
     * @cfg {String} left_field_name Record NS-left bound field name.
     */
app/assets/javascripts/ext_extensions/TreeGrid/TreeGrid.js on lines 1008..1114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 757.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Ext.ux.maximgb.tg.NestedSetStore = Ext.extend(Ext.ux.maximgb.tg.AbstractTreeStore,
{
    /**
     * @cfg {String} left_field_name Record NS-left bound field name.
     */
Severity: Major
Found in app/assets/javascripts/ext_extensions/TreeGrid/TreeGrid.js and 1 other location - About 4 days to fix
app/assets/javascripts/ext_extensions/TreeGrid/src/NestedSetStore.js on lines 4..110

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 757.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Ext.util.TaskRunner = function(interval){
    interval = interval || 10;
    var tasks = [], 
        removeQueue = [],
        id = 0,
Severity: Major
Found in app/assets/javascripts/ext/adapter/ext/ext-base-debug.js and 3 other locations - About 4 days to fix
app/assets/javascripts/ext/adapter/jquery/ext-jquery-adapter-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/prototype/ext-prototype-adapter-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/yui/ext-yui-adapter-debug.js on lines 1085..1205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 736.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Ext.util.TaskRunner = function(interval){
    interval = interval || 10;
    var tasks = [], 
        removeQueue = [],
        id = 0,
app/assets/javascripts/ext/adapter/ext/ext-base-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/prototype/ext-prototype-adapter-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/yui/ext-yui-adapter-debug.js on lines 1085..1205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 736.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Ext.util.TaskRunner = function(interval){
    interval = interval || 10;
    var tasks = [], 
        removeQueue = [],
        id = 0,
app/assets/javascripts/ext/adapter/ext/ext-base-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/jquery/ext-jquery-adapter-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/yui/ext-yui-adapter-debug.js on lines 1085..1205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 736.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Ext.util.TaskRunner = function(interval){
    interval = interval || 10;
    var tasks = [], 
        removeQueue = [],
        id = 0,
app/assets/javascripts/ext/adapter/ext/ext-base-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/jquery/ext-jquery-adapter-debug.js on lines 1085..1205
app/assets/javascripts/ext/adapter/prototype/ext-prototype-adapter-debug.js on lines 1085..1205

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 736.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File GridView.js has 1504 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
Severity: Major
Found in app/assets/javascripts/ext/src/widgets/grid/GridView.js - About 4 days to fix

    File TreeGrid.js has 1408 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    if (Ext.version == '3.0') {
        Ext.override(Ext.grid.GridView, {
            ensureVisible : function(row, col, hscroll) {
            
                var resolved = this.resolveCell(row, col, hscroll);
    Severity: Major
    Found in app/assets/javascripts/ext_extensions/TreeGrid/TreeGrid.js - About 3 days to fix

      Function Event has a Cognitive Complexity of 173 (exceeds 5 allowed). Consider refactoring.
      Open

      Ext.lib.Event = function() {
          var loadComplete = false,
              unloadListeners = {},
              retryCount = 0,
              onAvailStack = [],
      Severity: Minor
      Found in app/assets/javascripts/ext/src/ext-core/src/adapter/ext-base-event.js - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function swfobject has 663 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var swfobject = function() {
          
          var UNDEF = "undefined",
              OBJECT = "object",
              SHOCKWAVE_FLASH = "Shockwave Flash",
      Severity: Major
      Found in app/assets/javascripts/ext/src/widgets/chart/swfobject.js - About 3 days to fix

        Function DomQuery has 650 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Ext.DomQuery = function(){
            var cache = {}, 
                simpleCache = {}, 
                valueCache = {},
                nonSpace = /\S/,
        Severity: Major
        Found in app/assets/javascripts/ext/src/ext-core/src/core/DomQuery.js - About 3 days to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (tooNarrow) {
                      for (i = 0, length = visibleCount; i < length; i++) {
                          boxes[i].height = visibleItems[i].minHeight || visibleItems[i].height || boxes[i].height;
                      }
                  } else {
          Severity: Major
          Found in app/assets/javascripts/ext/src/widgets/layout/VBoxLayout.js and 1 other location - About 3 days to fix
          app/assets/javascripts/ext/src/widgets/layout/HBoxLayout.js on lines 153..236

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 555.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (tooNarrow) {
                      for (i = 0; i < visibleCount; i++) {
                          boxes[i].width = visibleItems[i].minWidth || visibleItems[i].width || boxes[i].width;
                      }
                  } else {
          Severity: Major
          Found in app/assets/javascripts/ext/src/widgets/layout/HBoxLayout.js and 1 other location - About 3 days to fix
          app/assets/javascripts/ext/src/widgets/layout/VBoxLayout.js on lines 154..237

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 555.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function() {
              // Scroll Animation
              var EXTLIB = Ext.lib;
              EXTLIB.Anim.scroll = function(el, args, duration, easing, cb, scope) {
                  return EXTLIB.Anim.run(el, args, duration, easing, cb, scope, EXTLIB.Scroll);
          Severity: Major
          Found in app/assets/javascripts/ext/adapter/ext/ext-base-debug.js and 1 other location - About 2 days to fix
          app/assets/javascripts/ext/src/ext-core/src/adapter/ext-base-anim-extra.js on lines 249..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 497.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          (function() {
              // Scroll Animation
              var EXTLIB = Ext.lib;
              EXTLIB.Anim.scroll = function(el, args, duration, easing, cb, scope) {
                  return EXTLIB.Anim.run(el, args, duration, easing, cb, scope, EXTLIB.Scroll);
          app/assets/javascripts/ext/adapter/ext/ext-base-debug.js on lines 2816..2872

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 497.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File DDCore.js has 1122 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*!
           * Ext JS Library 3.3.0
           * Copyright(c) 2006-2010 Ext JS, Inc.
           * licensing@extjs.com
           * http://www.extjs.com/license
          Severity: Major
          Found in app/assets/javascripts/ext/src/dd/DDCore.js - About 2 days to fix

            Function DomHelper has a Cognitive Complexity of 132 (exceeds 5 allowed). Consider refactoring.
            Open

            Ext.DomHelper = function(){
                var tempTableEl = null,
                    emptyTags = /^(?:br|frame|hr|img|input|link|meta|range|spacer|wbr|area|param|col)$/i,
                    tableRe = /^table|tbody|tr|td$/i,
                    confRe = /tag|children|cn|html$/i,
            Severity: Minor
            Found in app/assets/javascripts/ext/src/ext-core/src/core/DomHelper.js - About 2 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            if (Ext.version == '3.0') {
                Ext.override(Ext.grid.GridView, {
                    ensureVisible : function(row, col, hscroll) {
                    
                        var resolved = this.resolveCell(row, col, hscroll);
            app/assets/javascripts/ext_extensions/TreeGrid/TreeGrid.js on lines 1..51

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 457.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            if (Ext.version == '3.0') {
                Ext.override(Ext.grid.GridView, {
                    ensureVisible : function(row, col, hscroll) {
                    
                        var resolved = this.resolveCell(row, col, hscroll);
            Severity: Major
            Found in app/assets/javascripts/ext_extensions/TreeGrid/TreeGrid.js and 1 other location - About 2 days to fix
            app/assets/javascripts/ext_extensions/TreeGrid/src/ExtOverride.js on lines 1..51

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 457.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function DragDropMgr has 520 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            Ext.dd.DragDropMgr = function() {
            
                var Event = Ext.EventManager;
            
                return {
            Severity: Major
            Found in app/assets/javascripts/ext/src/dd/DDCore.js - About 2 days to fix
              Severity
              Category
              Status
              Source
              Language