talho/openphin

View on GitHub

Showing 3,486 of 3,486 total issues

File ext-lang-nl.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Ext JS Library 3.3.0
 * Copyright(c) 2006-2010 Ext JS, Inc.
 * licensing@extjs.com
 * http://www.extjs.com/license
Severity: Minor
Found in app/assets/javascripts/ext/src/locale/ext-lang-nl.js - About 2 hrs to fix

    Function getDialog has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            getDialog : function(titleText){
               if(!dlg){
                    var btns = [];
                    
                    buttons = {};
    Severity: Major
    Found in app/assets/javascripts/ext/src/widgets/MessageBox.js - About 2 hrs to fix

      File Element.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*!
       * Ext JS Library 3.3.0
       * Copyright(c) 2006-2010 Ext JS, Inc.
       * licensing@extjs.com
       * http://www.extjs.com/license
      Severity: Minor
      Found in app/assets/javascripts/ext/src/ext-core/src/core/Element.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            next: function() {
                if(this.fireEvent('beforenext') === false) {
                    return;
                }
                if(this.pauseOnNavigate) {
        app/assets/javascripts/ext/src/ext-core/examples/carousel/carousel.js on lines 173..184

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            prev: function() {
                if (this.fireEvent('beforeprev') === false) {
                    return;
                }
                if(this.pauseOnNavigate) {
        app/assets/javascripts/ext/src/ext-core/examples/carousel/carousel.js on lines 186..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File ext-lang-en_GB.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*!
         * Ext JS Library 3.3.0
         * Copyright(c) 2006-2010 Ext JS, Inc.
         * licensing@extjs.com
         * http://www.extjs.com/license
        Severity: Minor
        Found in app/assets/javascripts/ext/src/locale/ext-lang-en_GB.js - About 2 hrs to fix

          File ext-base-ajax.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          /*!
           * Ext JS Library 3.3.0
           * Copyright(c) 2006-2010 Ext JS, Inc.
           * licensing@extjs.com
           * http://www.extjs.com/license
          Severity: Minor
          Found in app/assets/javascripts/ext/src/ext-core/src/adapter/ext-base-ajax.js - About 2 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                    if ( event.pageX == null && event.clientX != null ) {
                        var doc = document.documentElement, body = document.body;
                        event.pageX = event.clientX + (doc && doc.scrollLeft || body && body.scrollLeft || 0) - (doc.clientLeft || 0);
                        event.pageY = event.clientY + (doc && doc.scrollTop || body && body.scrollTop || 0) - (doc.clientTop || 0);
                    }
            Severity: Critical
            Found in app/assets/javascripts/jquery.js - About 2 hrs to fix

              TreePanel has 24 functions (exceeds 20 allowed). Consider refactoring.
              Open

              Ext.tree.TreePanel = Ext.extend(Ext.Panel, {
                  rootVisible : true,
                  animate : Ext.enableFx,
                  lines : true,
                  enableDD : false,
              Severity: Minor
              Found in app/assets/javascripts/ext/src/widgets/tree/TreePanel.js - About 2 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                        if ( event.pageX == null && event.clientX != null ) {
                            var doc = document.documentElement, body = document.body;
                            event.pageX = event.clientX + (doc && doc.scrollLeft || body && body.scrollLeft || 0) - (doc.clientLeft || 0);
                            event.pageY = event.clientY + (doc && doc.scrollTop || body && body.scrollTop || 0) - (doc.clientTop || 0);
                        }
                Severity: Critical
                Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js - About 2 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if ( status == "success" || status == "notmodified" )
                                      // See if a selector was specified
                                      self.html( selector ?
                                          // Create a dummy div to hold the results
                                          jQuery("<div/>")
                  Severity: Major
                  Found in app/assets/javascripts/jquery.js and 1 other location - About 2 hrs to fix
                  app/assets/javascripts/jquery-tooltip/lib/jquery.js on lines 2411..2424

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  if ( status == "success" || status == "notmodified" )
                                      // See if a selector was specified
                                      self.html( selector ?
                                          // Create a dummy div to hold the results
                                          jQuery("<div/>")
                  Severity: Major
                  Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js and 1 other location - About 2 hrs to fix
                  app/assets/javascripts/jquery.js on lines 3265..3278

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          callback: function(json) {
                              _current.callback.apply(_current.scope, [json]);
                              Ext.fly(_current.script).removeAllListeners();
                              document.getElementsByTagName('head')[0].removeChild(_current.script);
                              _nextRequest();
                  app/assets/javascripts/ext_extensions/jsonp.js on lines 68..73

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      callback : function(json) {
                        _current.callback.apply(_current.scope, [json]);
                        Ext.fly(_current.script).removeAllListeners();
                        document.getElementsByTagName('head')[0].removeChild(_current.script);
                        _nextRequest();
                  Severity: Major
                  Found in app/assets/javascripts/ext_extensions/jsonp.js and 1 other location - About 2 hrs to fix
                  app/assets/javascripts/ext/src/ext-core/examples/jsonp/jsonp.js on lines 71..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 88.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function Registry has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Ext.dd.Registry = function(){
                      var elements = {}; 
                      var handles = {}; 
                      var autoIdSeed = 0;
                  
                  
                  Severity: Major
                  Found in app/assets/javascripts/ext/src/dd/Registry.js - About 2 hrs to fix

                    Function getAlignToXY has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        getAlignToXY : function(el, p, o){        
                            el = Ext.get(el);
                            
                            if(!el || !el.dom){
                                throw "Element.alignToXY with an element that doesn't exist";
                    Severity: Major
                    Found in app/assets/javascripts/ext/src/core/Element.alignment.js - About 2 hrs to fix

                      Function render has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          render : function(container, position){
                              if(!this.rendered && this.fireEvent('beforerender', this) !== false){
                                  if(!container && this.el){
                                      this.el = Ext.get(this.el);
                                      container = this.el.dom.parentNode;
                      Severity: Major
                      Found in app/assets/javascripts/ext/src/widgets/Component.js - About 2 hrs to fix

                        File Observable.js has 276 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /*!
                         * Ext JS Library 3.3.0
                         * Copyright(c) 2006-2010 Ext JS, Inc.
                         * licensing@extjs.com
                         * http://www.extjs.com/license
                        Severity: Minor
                        Found in app/assets/javascripts/ext/src/ext-core/src/util/Observable.js - About 2 hrs to fix

                          File ext-lang-es.js has 275 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          /*!
                           * Ext JS Library 3.3.0
                           * Copyright(c) 2006-2010 Ext JS, Inc.
                           * licensing@extjs.com
                           * http://www.extjs.com/license
                          Severity: Minor
                          Found in app/assets/javascripts/ext/src/locale/ext-lang-es.js - About 2 hrs to fix

                            Function initList has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                initList : function(){
                                    if(!this.list){
                                        var cls = 'x-combo-list',
                                            listParent = Ext.getDom(this.getListParent() || Ext.getBody());
                            
                            
                            Severity: Major
                            Found in app/assets/javascripts/ext/src/widgets/form/Combo.js - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language