talho/openphin

View on GitHub

Showing 3,486 of 3,486 total issues

Function handleTransactionResponse has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function handleTransactionResponse(o, callback, isAbort, isTimeout) {
        if (!callback) {
            releaseObject(o);
            return;
        }
Severity: Major
Found in app/assets/javascripts/ext/src/ext-core/src/adapter/ext-base-ajax.js - About 2 hrs to fix

    Function setVisible has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            setVisible : function(visible, animate){
                var me = this, isDisplay, isVisibility, isOffsets, isNosize,
                    dom = me.dom,
                    visMode = getVisMode(dom);
    
    
    Severity: Major
    Found in app/assets/javascripts/ext/src/ext-core/src/core/Element.fx.js - About 2 hrs to fix

      Function handleTransactionResponse has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function handleTransactionResponse(o, callback, isAbort, isTimeout) {
              if (!callback) {
                  releaseObject(o);
                  return;
              }
      Severity: Major
      Found in app/assets/javascripts/ext/adapter/ext/ext-base-debug.js - About 2 hrs to fix

        Function JsonP has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Ext.ux.JsonP = (function() {
          var _queue = [], _current = null, _callback = 'callback', _nextRequest = function() {
            _current = null;
            if(_queue.length) {
              _current = _queue.shift();
        Severity: Major
        Found in app/assets/javascripts/ext_extensions/jsonp.js - About 2 hrs to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              get: function( url, data, callback, type ) {
                  // shift arguments if data argument was ommited
                  if ( jQuery.isFunction( data ) ) {
                      callback = data;
                      data = null;
          Severity: Major
          Found in app/assets/javascripts/jquery.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/jquery-tooltip/lib/jquery.js on lines 2467..2481

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              get: function( url, data, callback, type ) {
                  // shift arguments if data argument was ommited
                  if ( jQuery.isFunction( data ) ) {
                      callback = data;
                      data = null;
          Severity: Major
          Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/jquery.js on lines 3322..3336

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              easing: {
                  linear: function( p, n, firstNum, diff ) {
                      return firstNum + diff * p;
                  },
                  swing: function( p, n, firstNum, diff ) {
          Severity: Major
          Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/jquery.js on lines 3991..3998

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              setYAxes : function(value){
                  var axis;
                  for(var i = 0; i < value.length; i++) {
                      axis = this.createAxis('yAxis' + i, value[i]);
                      this.swf.setVerticalAxis(axis);
          Severity: Major
          Found in app/assets/javascripts/ext/src/widgets/chart/Chart.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/ext/src/widgets/chart/Chart.js on lines 487..493

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              easing: {
                  linear: function( p, n, firstNum, diff ) {
                      return firstNum + diff * p;
                  },
                  swing: function( p, n, firstNum, diff ) {
          Severity: Major
          Found in app/assets/javascripts/jquery.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/jquery-tooltip/lib/jquery.js on lines 3099..3106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              setXAxes : function(value){
                  var axis;
                  for(var i = 0; i < value.length; i++) {
                      axis = this.createAxis('xAxis' + i, value[i]);
                      this.swf.setHorizontalAxis(axis);
          Severity: Major
          Found in app/assets/javascripts/ext/src/widgets/chart/Chart.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/ext/src/widgets/chart/Chart.js on lines 500..506

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File Index.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          Ext.ns("Talho.Forums.view.Topics");
          
          Talho.Forums.view.Topics.Index = Ext.extend(Ext.Panel, {
            autoHeight: true,
            constructor : function() {
          Severity: Minor
          Found in app/assets/javascripts/forums/view/topics/Index.js - About 2 hrs to fix

            FormPanel has 22 functions (exceeds 20 allowed). Consider refactoring.
            Open

            Ext.FormPanel = Ext.extend(Ext.Panel, {
                /**
                 * @cfg {String} formId (optional) The id of the FORM tag (defaults to an auto-generated id).
                 */
                /**
            Severity: Minor
            Found in app/assets/javascripts/ext/src/widgets/form/Form.js - About 2 hrs to fix

              TextField has 22 functions (exceeds 20 allowed). Consider refactoring.
              Open

              Ext.form.TextField = Ext.extend(Ext.form.Field,  {
                  /**
                   * @cfg {String} vtypeText A custom error message to display in place of the default message provided
                   * for the <b><code>{@link #vtype}</code></b> currently set for this field (defaults to <tt>''</tt>).  <b>Note</b>:
                   * only applies if <b><code>{@link #vtype}</code></b> is set, else ignored.
              Severity: Minor
              Found in app/assets/javascripts/ext/src/widgets/form/TextField.js - About 2 hrs to fix

                Consider simplifying this complex logical expression.
                Open

                            if ( !requestDone && xml && (xml.readyState == 4 || isTimeout == "timeout") ) {
                                requestDone = true;
                                
                                // clear poll interval
                                if (ival) {
                Severity: Critical
                Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js - About 2 hrs to fix

                  Function filter has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  Sizzle.filter = function(expr, set, inplace, not){
                      var old = expr, result = [], curLoop = set, match, anyFound,
                          isXMLFilter = set && set[0] && isXML(set[0]);
                  
                      while ( expr && set.length ) {
                  Severity: Major
                  Found in app/assets/javascripts/jquery.js - About 2 hrs to fix

                    Function initComponent has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      initComponent: function(){
                        this.addEvents('newgroup', 'groupdetail');
                        
                        var store = new Ext.data.JsonStore({ restful: true, url: '/admin/groups.json', root: 'groups', idProperty: 'id', remoteSort: 'true',
                          totalProperty: 'count', per_page: 10, paramNames:{
                    Severity: Major
                    Found in app/assets/javascripts/groups/view/list.js - About 2 hrs to fix

                      Function getTargetXY has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          getTargetXY : function(){
                              if(this.delegate){
                                  this.anchorTarget = this.triggerElement;
                              }
                              if(this.anchor){
                      Severity: Major
                      Found in app/assets/javascripts/ext/src/widgets/tips/ToolTip.js - About 2 hrs to fix

                        Function QuickTips has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        Ext.QuickTips = function(){
                            var tip,
                                disabled = false;
                                
                            return {
                        Severity: Major
                        Found in app/assets/javascripts/ext/src/widgets/tips/QuickTips.js - About 2 hrs to fix

                          Function slideOut has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              slideOut : function(anchor, o){
                                  o = getObject(o);
                                  var me = this,
                                      dom = me.dom,
                                      st = dom.style,
                          Severity: Major
                          Found in app/assets/javascripts/ext/src/ext-core/src/core/Fx.js - About 2 hrs to fix

                            Function doRender has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    doRender : function(cs, rs, ds, startRow, colCount, stripe)
                                    {
                                        var filtered = ds.isFiltered();
                                        var ts = this.templates, ct = ts.cell, rt = ts.row, last = colCount-1;
                                        var tstyle = 'width:'+this.getTotalWidth()+';';
                            Severity: Major
                            Found in app/assets/javascripts/ext_extensions/TreeGrid/Overrides.js - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language