talho/openphin

View on GitHub

Showing 3,486 of 3,486 total issues

Function animate has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    animate: function( prop, speed, easing, callback ) {
        var optall = jQuery.speed(speed, easing, callback);

        return this[ optall.queue === false ? "each" : "queue" ](function(){
            if ( this.nodeType != 1)
Severity: Minor
Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js - About 1 hr to fix

    Function add has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        add: function(elem, types, handler, data) {
            if ( elem.nodeType == 3 || elem.nodeType == 8 )
                return;
    
            // For whatever reason, IE has trouble passing the window object
    Severity: Minor
    Found in app/assets/javascripts/jquery-tooltip/lib/jquery.js - About 1 hr to fix

      Function setupDropZone has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          setupDropZone: function(ct){
              ct.dropZone = new Ext.dd.DropTarget(ct.getEl().dom, {
                  ddGroup:'TabPanelDD',
                  parent: this,
                  buttonPanel: ct,
      Severity: Minor
      Found in app/assets/javascripts/dashboard/favorites.js - About 1 hr to fix

        Method show has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def show
            @invitation = Invitation.find(params[:id])
            respond_to do |format|
              format.html
              format.json do
        Severity: Minor
        Found in app/controllers/admin/invitations_controller.rb - About 1 hr to fix

          Function animate has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              animate: function( prop, speed, easing, callback ) {
                  var optall = jQuery.speed(speed, easing, callback);
          
                  return this[ optall.queue === false ? "each" : "queue" ](function(){
                  
          Severity: Minor
          Found in app/assets/javascripts/jquery.js - About 1 hr to fix

            Function decodeValue has 40 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                decodeValue : function(cookie){
                    /**
                     * a -> Array
                     * n -> Number
                     * d -> Date
            Severity: Minor
            Found in app/assets/javascripts/ext/src/state/Provider.js - About 1 hr to fix

              Function applyState has 40 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  applyState : function(state){
                      var cm = this.colModel,
                          cs = state.columns,
                          store = this.store,
                          s,
              Severity: Minor
              Found in app/assets/javascripts/ext/src/widgets/grid/GridPanel.js - About 1 hr to fix

                Function beforeDestroy has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    beforeDestroy : function(){
                        Ext.Panel.superclass.beforeDestroy.call(this);
                        if(this.header){
                            this.header.removeAllListeners();
                        }
                Severity: Minor
                Found in app/assets/javascripts/ext/src/widgets/Panel.js - About 1 hr to fix

                  Function setRunAttr has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                              setRunAttr: function(attr){
                                  if(pointsRe.test(attr)){
                  
                                      var me = this,
                                          el = this.el,

                    Function readResponse has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        readResponse : function(action, response) {
                            var dataRequired = action === Ext.data.Api.actions.create || action === Ext.data.Api.actions.read;
                            var o = (response.responseText !== undefined) ? Ext.decode(response.responseText) : response;
                            if (!o) {
                                if(dataRequired)
                    Severity: Minor
                    Found in app/assets/javascripts/ext_extensions/RailsJsonReader.js - About 1 hr to fix

                      Function setRunAttr has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                                  setRunAttr: function(attr){
                                      if(pointsRe.test(attr)){
                      
                                          var me = this,
                                              el = this.el,
                      Severity: Minor
                      Found in app/assets/javascripts/ext/adapter/ext/ext-base-debug.js - About 1 hr to fix

                        Function loadRecords has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            loadRecords: function (o, options, success) {
                                if (this.isDestroyed === true) {
                                    return;
                                }
                                if (!o || success === false) {
                        Severity: Minor
                        Found in app/assets/javascripts/ext_extensions/PagingStore.js - About 1 hr to fix

                          Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            constructor: function(config){
                              this.dshsEmailButton = new Ext.Button({
                                text: 'Email TXPHIN Admin',
                                handler: function(){
                                  window.location = 'mailto:phinadmin@dshs.state.tx.us?body=\'TxPHIN help request\'';
                          Severity: Minor
                          Found in app/assets/javascripts/dashboard/help_window.js - About 1 hr to fix

                            Function buildMenu has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                buildMenu: function(menuConfig)
                                {
                                    // check and see if a string was sent in. These will be things like '->', ' ' and '-' for the fill, spacer, and separator shortcuts
                                    if(Ext.isString(menuConfig))
                                        return menuConfig;
                            Severity: Minor
                            Found in app/assets/javascripts/dashboard/menu_builder.js - About 1 hr to fix

                              Method deny has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                def deny
                                  role_req=RoleRequest.find(params[:id])
                                  if role_req
                                    if current_user.is_admin_for?(role_req.jurisdiction)
                                      role_req.deny!
                              Severity: Minor
                              Found in app/controllers/admin/role_requests_controller.rb - About 1 hr to fix

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    onItemTitleChanged : function(item){
                                        var el = this.getTabEl(item);
                                        if(el){
                                            Ext.fly(el).child('span.x-tab-strip-text', true).innerHTML = item.title;
                                        }
                                Severity: Major
                                Found in app/assets/javascripts/ext/src/widgets/TabPanel.js and 1 other location - About 1 hr to fix
                                app/assets/javascripts/ext_extensions/VerticalTabPanel/Ext.ux.tot2ivn.VrTabPanel.js on lines 508..513

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    onStripContextMenu : function(e){
                                        e.preventDefault();
                                        var t = this.findTargets(e);
                                        if(t.item){
                                            this.fireEvent('contextmenu', this, t.item, e);
                                app/assets/javascripts/ext/src/widgets/TabPanel.js on lines 479..485

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    onItemTitleChanged : function(item){
                                        var el = this.getTabEl(item);
                                        if(el){
                                            Ext.fly(el).child('span.x-tab-strip-text', true).innerHTML = item.title;
                                        }
                                app/assets/javascripts/ext/src/widgets/TabPanel.js on lines 665..670

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Identical blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    onStripContextMenu : function(e){
                                        e.preventDefault();
                                        var t = this.findTargets(e);
                                        if(t.item){
                                            this.fireEvent('contextmenu', this, t.item, e);
                                Severity: Major
                                Found in app/assets/javascripts/ext/src/widgets/TabPanel.js and 1 other location - About 1 hr to fix
                                app/assets/javascripts/ext_extensions/VerticalTabPanel/Ext.ux.tot2ivn.VrTabPanel.js on lines 319..325

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                    sequenceFx : function(){
                                        var me = this;
                                        me.fxDefaults = Ext.apply(me.fxDefaults || {}, {
                                            block : FALSE,
                                            concurrent : FALSE,
                                Severity: Major
                                Found in app/assets/javascripts/ext/src/ext-core/src/core/Fx.js and 1 other location - About 1 hr to fix
                                app/assets/javascripts/ext/src/ext-core/src/core/Fx.js on lines 917..925

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 67.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language