Sign upLogin

tapestry-cloud/tapestry

View on GitHub
Star
src/Console/Commands/Command.php

Summary

Maintainability
A
25 mins
Test Coverage
F
55%

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(InputInterface $input, OutputInterface $output)
    {
        try {
            $this->input = $input;
            $this->output = $output;
Severity: Minor
Found in src/Console/Commands/Command.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method panic() contains an exit expression.
Open

        exit($code);
Severity: Minor
Found in src/Console/Commands/Command.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Line exceeds 120 characters; contains 147 characters
Open

                throw new LockException('Tapestry is already running; please wait for the previous process to complete or delete the .lock file.');
Severity: Minor
Found in src/Console/Commands/Command.php by phpcodesniffer

Line exceeds 120 characters; contains 167 characters
Open

        $this->output->writeln('Task complete in: '.$stopwatch.'s ['.file_size_convert(memory_get_usage(true)).'/'.file_size_convert(memory_get_peak_usage(true)).']');
Severity: Minor
Found in src/Console/Commands/Command.php by phpcodesniffer

There are no issues that match your filters.

Category
Status