src/Entities/Generators/CollectionItemGenerator.php
Avoid assigning values to variables in if clauses and the like (line '21', column '13'). Open
Open
public function generate(Project $project)
{
$newFile = clone $this->file;
$newFile->setData([
'generator' => array_filter($this->file->getData('generator'), function ($value) {- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Line exceeds 120 characters; contains 125 characters Open
Open
// If we are the last page, then Pagination will only have two pages (this and the previous one), also there will- Exclude checks
Line exceeds 120 characters; contains 125 characters Open
Open
// If we are the first page, then Pagination will only have two pages (this and the next one), also there will be- Exclude checks
Line exceeds 120 characters; contains 134 characters Open
Open
// @todo check to see if 'item' should be set within the view's scope; it feels weird that this is the only generator doing so- Exclude checks