tapestry-cloud/tapestry

View on GitHub
src/Entities/Url.php

Summary

Maintainability
B
6 hrs
Test Coverage
A
98%

Function encodePart has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    private function encodePart($part)
    {
        if (strpos($part, '?') !== false) {
            if (strpos($part, '?') === 0) {
                $output = '?';
Severity: Minor
Found in src/Entities/Url.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encodePart has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function encodePart($part)
    {
        if (strpos($part, '?') !== false) {
            if (strpos($part, '?') === 0) {
                $output = '?';
Severity: Minor
Found in src/Entities/Url.php - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if (
                strlen($e) > 0 &&
                strpos($e, '?') === false &&
                strpos($e, '=') === false &&
                strpos($e, '&') === false &&
    Severity: Major
    Found in src/Entities/Url.php - About 40 mins to fix

      Avoid too many return statements within this method.
      Open

              return rawurlencode($part);
      Severity: Major
      Found in src/Entities/Url.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $pe[0].'/#'.rawurlencode($pe[1]);
        Severity: Major
        Found in src/Entities/Url.php - About 30 mins to fix

          Function encode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function encode($uri = '')
              {
                  $parts = explode('/', $uri);
                  foreach ($parts as &$part) {
                      if (strpos($part, 'index') !== false) {
          Severity: Minor
          Found in src/Entities/Url.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method encodePart() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              private function encodePart($part)
              {
                  if (strpos($part, '?') !== false) {
                      if (strpos($part, '?') === 0) {
                          $output = '?';
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Missing class import via use statement (line '41', column '23').
          Open

                      throw new \Exception('The site url is not set in your site configuration.');
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
              return new \stdClass();
          }

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Avoid assigning values to variables in if clauses and the like (line '40', column '15').
          Open

              private function loadSiteUrl()
              {
                  if (! is_null($this->siteUrl)) {
                      return $this->siteUrl;
                  }
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid variables with short names like $pe. Configured minimum length is 3.
          Open

                          $pe = explode('?', $part);
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $e. Configured minimum length is 3.
          Open

                  $e = end($parts);
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $p. Configured minimum length is 3.
          Open

                      foreach ($parts as &$p) {
          Severity: Minor
          Found in src/Entities/Url.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
              private $q = 15; // VIOLATION - Field
              public static function main( array $as ) { // VIOLATION - Formal
                  $r = 20 + $this->q; // VIOLATION - Local
                  for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                      $r += $this->q;
                  }
              }
          }

          Source https://phpmd.org/rules/naming.html#shortvariable

          Expected 0 spaces after opening bracket; newline found
          Open

                  if (
          Severity: Minor
          Found in src/Entities/Url.php by phpcodesniffer

          There are no issues that match your filters.

          Category
          Status